From: Tom Lane <tgl@sss.pgh.pa.us>
To: Peter Geoghegan <pg@bowt.ie>
cc: Andres Freund <andres@anarazel.de>,
        Dmitry Mityugov <d.mityugov@postgrespro.ru>,
        pgsql-hackers@postgresql.org
Subject: Re: patch: Use pg_assume in jsonb_util.c to fix GCC 15 warnings
In-reply-to: 
 <CAH2-WzkXwnY=cNGDODOyW=AhT4H8Rj7MiOk3mcN=Ua2w8C=RZg@mail.gmail.com>
References: <0c623e8a204187b87b4736792398eaf1@postgrespro.ru>
 <82868.1752342174@sss.pgh.pa.us>
 <ib5yhkzseb27icjpz5p6wqgppaoa2nhjzj3ldx23d65ehciwin@um6dx2bpxux3>
 <CAH2-WzkXwnY=cNGDODOyW=AhT4H8Rj7MiOk3mcN=Ua2w8C=RZg@mail.gmail.com>
Comments: In-reply-to Peter Geoghegan <pg@bowt.ie>
	message dated "Tue, 15 Jul 2025 18:35:01 -0400"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <1138042.1752620290.1@sss.pgh.pa.us>
Date: Tue, 15 Jul 2025 18:58:10 -0400
Message-ID: <1138043.1752620290@sss.pgh.pa.us>
Archived-At: 
 <https://www.postgresql.org/message-id/1138043.1752620290%40sss.pgh.pa.us>
Precedence: bulk

Peter Geoghegan <pg@bowt.ie> writes:
> In the past, it was often necessary to work around MSVC's inability to
> see that a block containing elog(ERROR) doesn't actually need to
> initialize variables that'll never actually be used in code that comes
> after that block. We still have many "keep compiler quiet" variable
> initializations due to this.

> Is that still something that we need to worry about?

Good question.  It's not very clear what set of compiler versions
people are still using, but maybe it'd be okay to stop worrying
about suppressing such warnings.

			regards, tom lane