Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1gsx4b-0002tM-Ue for pgsql-hackers@arkaria.postgresql.org; Sun, 10 Feb 2019 21:55:38 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.89) (envelope-from ) id 1gsx4a-0008Lc-9e for pgsql-hackers@arkaria.postgresql.org; Sun, 10 Feb 2019 21:55:36 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1gsx4a-0008LF-2W for pgsql-hackers@lists.postgresql.org; Sun, 10 Feb 2019 21:55:36 +0000 Received: from sss.pgh.pa.us ([66.207.139.130]) by magus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1gsx4Y-0008UC-4U for pgsql-hackers@lists.postgresql.org; Sun, 10 Feb 2019 21:55:35 +0000 Received: from sss1.sss.pgh.pa.us (localhost [127.0.0.1]) by sss.pgh.pa.us (8.14.4/8.14.4) with ESMTP id x1ALtUTG011414; Sun, 10 Feb 2019 16:55:30 -0500 From: Tom Lane To: Daniel Gustafsson cc: pgsql-hackers@lists.postgresql.org Subject: Re: Reporting script runtimes in pg_regress In-reply-to: References: <16646.1549770618@sss.pgh.pa.us> Comments: In-reply-to Daniel Gustafsson message dated "Sun, 10 Feb 2019 22:21:27 +0100" MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-ID: <11412.1549835730.1@sss.pgh.pa.us> Content-Transfer-Encoding: quoted-printable Date: Sun, 10 Feb 2019 16:55:30 -0500 Message-ID: <11413.1549835730@sss.pgh.pa.us> List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk Daniel Gustafsson writes: >> On 10 Feb 2019, at 04:50, Tom Lane wrote: >> Does anyone else feel that this is interesting/useful data? > Absolutely, +1 on this. In Greenplum we print the runtime of the script= and > the runtime of the diff, both of which have provided useful feedback on = where > to best spend optimization efforts (the diff time of course being a lot = less > interesting in upstream postgres due to gpdb having it=E2=80=99s own dif= f tool to > handle segment variability). Seems like I'm far from the first to think of this --- I wonder why nobody submitted a patch before? Anyway, pushed. regards, tom lane