Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1ubp3f-005i2c-2q for pgsql-hackers@arkaria.postgresql.org; Tue, 15 Jul 2025 23:27:35 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.94.2) (envelope-from ) id 1ubp3b-006EFf-Ax for pgsql-hackers@arkaria.postgresql.org; Tue, 15 Jul 2025 23:27:31 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1ubp3b-006EFX-1Q for pgsql-hackers@lists.postgresql.org; Tue, 15 Jul 2025 23:27:31 +0000 Received: from sss.pgh.pa.us ([68.162.161.243]) by makus.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1ubp3Z-007TzR-1k for pgsql-hackers@postgresql.org; Tue, 15 Jul 2025 23:27:30 +0000 Received: from sss1.sss.pgh.pa.us (localhost [127.0.0.1]) by sss.pgh.pa.us (8.15.2/8.15.2) with ESMTP id 56FNRIjK1141815; Tue, 15 Jul 2025 19:27:18 -0400 From: Tom Lane To: Peter Geoghegan cc: Andres Freund , Dmitry Mityugov , pgsql-hackers@postgresql.org Subject: Re: patch: Use pg_assume in jsonb_util.c to fix GCC 15 warnings In-reply-to: References: <0c623e8a204187b87b4736792398eaf1@postgrespro.ru> <82868.1752342174@sss.pgh.pa.us> <1138043.1752620290@sss.pgh.pa.us> Comments: In-reply-to Peter Geoghegan message dated "Tue, 15 Jul 2025 19:05:13 -0400" MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <1141813.1752622038.1@sss.pgh.pa.us> Date: Tue, 15 Jul 2025 19:27:18 -0400 Message-ID: <1141814.1752622038@sss.pgh.pa.us> List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk Peter Geoghegan writes: > It would be nice to eliminate all existing "keep compiler quiet" > variable initializations that follow an elog/ereport with elevel >= > ERROR. My guess is that we have several hundred. There are a lot of them, for sure. I'd be a bit worried about creating a back-patching mine-field. But maybe these are all in spots we're unlikely to touch? regards, tom lane