From: Tom Lane <tgl@sss.pgh.pa.us>
To: Sergei Kornilov <sk@zsrv.org>
cc: Alvaro Herrera <alvherre@alvh.no-ip.org>,
        Ildar Musin <i.musin@postgrespro.ru>,
        Stephen Frost <sfrost@snowman.net>,
        Robert Haas <robertmhaas@gmail.com>,
        "pgsql-hackers@postgresql.org" <pgsql-hackers@postgresql.org>
Subject: Re: using index or check in ALTER TABLE SET NOT NULL
In-reply-to: <1715451520361128@web26o.yandex.ru>
References: <880511520351578@web5j.yandex.ru>
 <20180306172528.xnelm3xcq2qeyd2g@alvherre.pgsql>
 <1715451520361128@web26o.yandex.ru>
Comments: In-reply-to Sergei Kornilov <sk@zsrv.org>
	message dated "Tue, 06 Mar 2018 21:32:08 +0300"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <1141.1520362313.1@sss.pgh.pa.us>
Content-Transfer-Encoding: quoted-printable
Date: Tue, 06 Mar 2018 13:51:53 -0500
Message-ID: <1142.1520362313@sss.pgh.pa.us>
Precedence: bulk

Sergei Kornilov <sk@zsrv.org> writes:
>> ISTM that depending on DEBUG messages is bad because debugging lines
>> added elsewhere will make your tests fail;

> I agree and this is reason why i not used DEBUG message in tests as was =
proposed. I found INFO messages in tests and decided that this was an acce=
ptable option year ago.

INFO is for user-facing messages, such as output from VACUUM VERBOSE,
where the user has specifically requested the output.  I do not think
this falls into that category.  Even if you persuade some committer
to commit it like that, there will be user pushback asking us to get
this noise out of their faces ... and then we'll have to find some
other way to test it.

Do you actually need test output proving that this code path was taken
rather than the default one?  Seems like looking at the code coverage
report might be enough.

> In this case we need remove INFO from ALTER TABLE ATTACH PARTITION code =
and tests. I think is a bad idea of using different rules for same stuff, =
right? Probably i can do this work too.

I did not see any INFO messages in a quick test of ALTER TABLE ATTACH
PARTITION, but if there are any lurking in there, they probably need
to be downgraded.

			regards, tom lane