Feedback-ID: ie0a040ee:Fastmail
Content-Type: multipart/mixed; boundary="------------XYxWZS2QIUhrzHF9zWrsjAMu"
Message-ID: <1142ad86-e475-41b3-aeee-c6ad913064fa@eisentraut.org>
Date: Sat, 11 Apr 2026 12:37:15 +0200
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Content-Language: en-US
From: Peter Eisentraut <peter@eisentraut.org>
Subject: some extra warnings from MSVC
To: pgsql-hackers <pgsql-hackers@postgresql.org>
Archived-At: 
 <https://www.postgresql.org/message-id/1142ad86-e475-41b3-aeee-c6ad913064fa%40eisentraut.org>
Precedence: bulk

This is a multi-part message in MIME format.
--------------XYxWZS2QIUhrzHF9zWrsjAMu
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit

I ran the MSVC build with the warning level set one level higher than 
the default (that is, meson -Dwarning_level=2, which actually maps to 
what MSVC considers its level 3), and it gave two new warnings that 
should be fixed:

../src/backend/utils/error/elog.c(1255): warning C4013: 'wchar2char' 
undefined; assuming extern returning int

../src/backend/utils/hash/dynahash.c(1767): warning C4334: '<<': result 
of 32-bit shift implicitly converted to 64 bits (was 64-bit shift intended?)

These are both in code that is new in PG19.

The first one is from commit 65707ed9afc (Add backtrace support for 
Windows).  This would be an error in gcc (from C99 on); it's kind of 
incredible that MSVC doesn't even warn about this by default.  I propose 
to add this warning category to the default set.

(Second thought: For consistency, make this an error, with '/we4013' 
instead of '/w24013'.)

The second one is from commit 13b935cd521 (Change dynahash.c and 
hsearch.h to use int64 instead of long).  I don't have a patch here to 
include this in the default warning set, mainly because it doesn't 
appear to map to any gcc warning option, but maybe we should add it 
anyway, since it can catch this kind of 4-byte-long-on-Windows issue.

--------------XYxWZS2QIUhrzHF9zWrsjAMu
Content-Type: text/plain; charset=UTF-8;
 name="0001-MSVC-Add-warning-for-missing-function-declaration.patch"
Content-Disposition: attachment;
 filename*0="0001-MSVC-Add-warning-for-missing-function-declaration.patch"
Content-Transfer-Encoding: base64

RnJvbSBiMDM0NTQzMGFlMWJhZTFjZWE3MDkyZmRlNTYyYWExMzdhYzhiMGM5IE1vbiBTZXAg
MTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBQZXRlciBFaXNlbnRyYXV0IDxwZXRlckBlaXNlbnRy
YXV0Lm9yZz4KRGF0ZTogU2F0LCAxMSBBcHIgMjAyNiAxMjoyMzoyMyArMDIwMApTdWJqZWN0
OiBbUEFUQ0ggMS8zXSBNU1ZDOiBBZGQgd2FybmluZyBmb3IgbWlzc2luZyBmdW5jdGlvbiBk
ZWNsYXJhdGlvbgoKLS0tCiBtZXNvbi5idWlsZCB8IDEgKwogMSBmaWxlIGNoYW5nZWQsIDEg
aW5zZXJ0aW9uKCspCgpkaWZmIC0tZ2l0IGEvbWVzb24uYnVpbGQgYi9tZXNvbi5idWlsZApp
bmRleCBiZTk3ZTk4NmU1ZC4uMjQwZDA4NjlhZjkgMTAwNjQ0Ci0tLSBhL21lc29uLmJ1aWxk
CisrKyBiL21lc29uLmJ1aWxkCkBAIC0yMzI4LDYgKzIzMjgsNyBAQCBpZiBjYy5nZXRfaWQo
KSA9PSAnbXN2YycKICAgICAnL3dkNDI0NCcsICMgY29udmVyc2lvbiBmcm9tICd0eXBlMScg
dG8gJ3R5cGUyJywgcG9zc2libGUgbG9zcyBvZiBkYXRhCiAKICAgICAjIEFkZGl0aW9uYWwg
d2FybmluZ3MgdG8gZW5hYmxlOgorICAgICcvdzI0MDEzJywgIyAnZnVuY3Rpb24nIHVuZGVm
aW5lZDsgYXNzdW1pbmcgZXh0ZXJuIHJldHVybmluZyBpbnQnIFtsaWtlIC1XaW1wbGljaXQt
ZnVuY3Rpb24tZGVjbGFyYXRpb25dCiAgICAgJy93MjQwNjInLCAjIGVudW1lcmF0b3IgJ2lk
ZW50aWZpZXInIGluIHN3aXRjaCBvZiBlbnVtICdlbnVtZXJhdGlvbicgaXMgbm90IGhhbmRs
ZWQgW2xpa2UgLVdzd2l0Y2hdCiAgICAgJy93MjQxMDInLCAjIHVucmVmZXJlbmNlZCBsYWJl
bCBbbGlrZSAtV3VudXNlZC1sYWJlbF0KICAgXQotLSAKMi41My4wCgo=
--------------XYxWZS2QIUhrzHF9zWrsjAMu
Content-Type: text/plain; charset=UTF-8;
 name="0002-MSVC-Add-missing-include.patch"
Content-Disposition: attachment;
 filename="0002-MSVC-Add-missing-include.patch"
Content-Transfer-Encoding: base64

RnJvbSA3ZTUwMzE1MjRjYzdmOTgxZTg1NmNkZDQ3MjZhMzY5NjZiMTlkYTYxIE1vbiBTZXAg
MTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBQZXRlciBFaXNlbnRyYXV0IDxwZXRlckBlaXNlbnRy
YXV0Lm9yZz4KRGF0ZTogU2F0LCAxMSBBcHIgMjAyNiAxMjoyMzoyMyArMDIwMApTdWJqZWN0
OiBbUEFUQ0ggMi8zXSBNU1ZDOiBBZGQgbWlzc2luZyBpbmNsdWRlCgouLi9zcmMvYmFja2Vu
ZC91dGlscy9lcnJvci9lbG9nLmMoMTI1NSk6IHdhcm5pbmcgQzQwMTM6ICd3Y2hhcjJjaGFy
JyB1bmRlZmluZWQ7IGFzc3VtaW5nIGV4dGVybiByZXR1cm5pbmcgaW50Ci0tLQogc3JjL2Jh
Y2tlbmQvdXRpbHMvZXJyb3IvZWxvZy5jIHwgMSArCiAxIGZpbGUgY2hhbmdlZCwgMSBpbnNl
cnRpb24oKykKCmRpZmYgLS1naXQgYS9zcmMvYmFja2VuZC91dGlscy9lcnJvci9lbG9nLmMg
Yi9zcmMvYmFja2VuZC91dGlscy9lcnJvci9lbG9nLmMKaW5kZXggYzI3MGM2MmUyMTMuLmFk
OTYwMzM2ZThkIDEwMDY0NAotLS0gYS9zcmMvYmFja2VuZC91dGlscy9lcnJvci9lbG9nLmMK
KysrIGIvc3JjL2JhY2tlbmQvdXRpbHMvZXJyb3IvZWxvZy5jCkBAIC04Niw2ICs4Niw3IEBA
CiAjaW5jbHVkZSAidGNvcC90Y29wcHJvdC5oIgogI2luY2x1ZGUgInV0aWxzL2d1Y19ob29r
cy5oIgogI2luY2x1ZGUgInV0aWxzL21lbXV0aWxzLmgiCisjaW5jbHVkZSAidXRpbHMvcGdf
bG9jYWxlLmgiCiAjaW5jbHVkZSAidXRpbHMvcHNfc3RhdHVzLmgiCiAjaW5jbHVkZSAidXRp
bHMvdmFybGVuYS5oIgogCi0tIAoyLjUzLjAKCg==
--------------XYxWZS2QIUhrzHF9zWrsjAMu
Content-Type: text/plain; charset=UTF-8;
 name="0003-Fix-64-bit-shifting-in-dynahash.c.patch"
Content-Disposition: attachment;
 filename="0003-Fix-64-bit-shifting-in-dynahash.c.patch"
Content-Transfer-Encoding: base64

RnJvbSBjNTcxNjBkZDBkNmNjNGJjMGViY2FjM2I1OGI4OTQyOGMwOTBkYTZjIE1vbiBTZXAg
MTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBQZXRlciBFaXNlbnRyYXV0IDxwZXRlckBlaXNlbnRy
YXV0Lm9yZz4KRGF0ZTogU2F0LCAxMSBBcHIgMjAyNiAxMjoyMzoyMyArMDIwMApTdWJqZWN0
OiBbUEFUQ0ggMy8zXSBGaXggNjQtYml0IHNoaWZ0aW5nIGluIGR5bmFoYXNoLmMKClRoZSBz
d2l0Y2ggZnJvbSBsb25nIHRvIGludDY0IGluIGNvbW1pdCAxM2I5MzVjZDUyMSB3YXMgaW5j
b21wbGV0ZS4KSXQgd2FzIHNoaWZ0aW5nIHRoZSBjb25zdGFudCAxTCwgd2hpY2ggaXMgbm90
IGFsd2F5cyA2NCBiaXQuICBGaXggYnkKdXNpbmcgYW4gZXhwbGljaXQgaW50NjQgY29uc3Rh
bnQuCgpNU1ZDIHdhcm5pbmc6CgouLi9zcmMvYmFja2VuZC91dGlscy9oYXNoL2R5bmFoYXNo
LmMoMTc2Nyk6IHdhcm5pbmcgQzQzMzQ6ICc8PCc6IHJlc3VsdCBvZiAzMi1iaXQgc2hpZnQg
aW1wbGljaXRseSBjb252ZXJ0ZWQgdG8gNjQgYml0cyAod2FzIDY0LWJpdCBzaGlmdCBpbnRl
bmRlZD8pCi0tLQogc3JjL2JhY2tlbmQvdXRpbHMvaGFzaC9keW5haGFzaC5jIHwgMiArLQog
MSBmaWxlIGNoYW5nZWQsIDEgaW5zZXJ0aW9uKCspLCAxIGRlbGV0aW9uKC0pCgpkaWZmIC0t
Z2l0IGEvc3JjL2JhY2tlbmQvdXRpbHMvaGFzaC9keW5haGFzaC5jIGIvc3JjL2JhY2tlbmQv
dXRpbHMvaGFzaC9keW5haGFzaC5jCmluZGV4IDIwNjEwZjk2ZTdiLi40NTk2ZTVjNzQ3NiAx
MDA2NDQKLS0tIGEvc3JjL2JhY2tlbmQvdXRpbHMvaGFzaC9keW5haGFzaC5jCisrKyBiL3Ny
Yy9iYWNrZW5kL3V0aWxzL2hhc2gvZHluYWhhc2guYwpAQCAtMTc2NCw3ICsxNzY0LDcgQEAg
c3RhdGljIGludDY0CiBuZXh0X3BvdzJfaW50NjQoaW50NjQgbnVtKQogewogCS8qIG15X2xv
ZzIncyBpbnRlcm5hbCByYW5nZSBjaGVjayBpcyBzdWZmaWNpZW50ICovCi0JcmV0dXJuIDFM
IDw8IG15X2xvZzIobnVtKTsKKwlyZXR1cm4gKGludDY0KSAxIDw8IG15X2xvZzIobnVtKTsK
IH0KIAogLyogY2FsY3VsYXRlIGZpcnN0IHBvd2VyIG9mIDIgPj0gbnVtLCBib3VuZGVkIHRv
IHdoYXQgd2lsbCBmaXQgaW4gYW4gaW50ICovCi0tIAoyLjUzLjAKCg==

--------------XYxWZS2QIUhrzHF9zWrsjAMu--