From: Tom Lane <tgl@sss.pgh.pa.us>
To: Nathan Bossart <nathandbossart@gmail.com>
cc: Fujii Masao <masao.fujii@oss.nttdata.com>,
        Andy Fan <zhihuifan1213@163.com>, pgsql-hackers@lists.postgresql.org
Subject: Re: pgbench error: (setshell) of script 0;
 execution of meta-command failed
In-reply-to: <724045.1736887918@sss.pgh.pa.us>
References: <87ikqn5em7.fsf@163.com>
 <e03fc711-8c48-4fb8-ba94-0862c920c30f@oss.nttdata.com>
 <b0afe844-84b7-4154-ad2c-6763ff84d876@oss.nttdata.com>
 <2422778.1736521065@sss.pgh.pa.us> <2425050.1736522451@sss.pgh.pa.us>
 <127979.1736622253@sss.pgh.pa.us> <Z4U5j_FWpNLjtdU8@nathan>
 <570943.1736808714@sss.pgh.pa.us> <Z4aRAdGdw8GiU7ba@nathan>
 <717458.1736884349@sss.pgh.pa.us> <Z4bN1z_Ce_lxldj4@nathan>
 <724045.1736887918@sss.pgh.pa.us>
Comments: In-reply-to Tom Lane <tgl@sss.pgh.pa.us>
	message dated "Tue, 14 Jan 2025 15:51:58 -0500"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <1143415.1736899081.1@sss.pgh.pa.us>
Date: Tue, 14 Jan 2025 18:58:01 -0500
Message-ID: <1143416.1736899081@sss.pgh.pa.us>
Archived-At: 
 <https://www.postgresql.org/message-id/1143416.1736899081%40sss.pgh.pa.us>
Precedence: bulk

I wrote:
> OK, I'll make it so.  Thanks for looking at it!

Or not.  My idea worked okay in v17, but not in older branches.
Pre-v17, libpq itself can call pqsignal (though only in non-
thread-safe builds).  With this patch, that would have resulted
in pulling src/port/pqsignal.o into libpq.  libpq itself is fine
with calling that version, but if a stub version of pqsignal()
comes along for the ride then we have two candidates for which
function will be exported.

It would probably be possible to fix that, say by making the
wrapper version be a separate .o module within libpgport.
But it would be more work and complication, and I couldn't
get excited about investing such effort for a hypothetical
build problem.  So I've pushed the patches as I originally
proposed them.  If anyone else is excited about doing something
more, step right up.

			regards, tom lane