From: Tom Lane <tgl@sss.pgh.pa.us>
To: Alvaro Herrera <alvherre@alvh.no-ip.org>
cc: "Drouvot, Bertrand" <bertranddrouvot.pg@gmail.com>,
        PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Subject: Re: Remove nonmeaningful prefixes in PgStat_* fields
In-reply-to: <20230112171252.xucefmthy5l4l2ec@alvherre.pgsql>
References: <20230112171252.xucefmthy5l4l2ec@alvherre.pgsql>
Comments: In-reply-to Alvaro Herrera <alvherre@alvh.no-ip.org>
	message dated "Thu, 12 Jan 2023 18:12:52 +0100"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <1144411.1673544209.1@sss.pgh.pa.us>
Date: Thu, 12 Jan 2023 12:23:29 -0500
Message-ID: <1144412.1673544209@sss.pgh.pa.us>
Archived-At: 
 <https://www.postgresql.org/message-id/1144412.1673544209%40sss.pgh.pa.us>
Precedence: bulk

Alvaro Herrera <alvherre@alvh.no-ip.org> writes:
> I don't like this at all.  With these prefixes in place, it's much more
> likely that you'll be able to grep the whole source tree and not run
> into tons of false positives.  If you remove them, that tends to be not
> very workable.  If we use these commits as precedent for expanding this
> sort of renaming across the tree, we'll soon end up with a very
> grep-unfriendly code base.

+1, that was my immediate fear as well.

			regards, tom lane