Received: from malur.postgresql.org ([217.196.149.56])
	by arkaria.postgresql.org with esmtp (Exim 4.84_2)
	(envelope-from
 <pgsql-hackers-owner+M315760=pgsql-hackers-arkari@postgresql.org>)
	id 1cW7KZ-0006Kj-2N
	for pgsql-hackers@arkaria.postgresql.org; Tue, 24 Jan 2017 20:04:39 +0000
Received: from localhost ([127.0.0.1] helo=postgresql.org)
	by malur.postgresql.org with smtp (Exim 4.84_2)
	(envelope-from
 <pgsql-hackers-owner+M315760=pgsql-hackers-arkari@postgresql.org>)
	id 1cW7KY-00031e-HC
	for pgsql-hackers@arkaria.postgresql.org; Tue, 24 Jan 2017 20:04:38 +0000
Received: from makus.postgresql.org ([2001:4800:1501:1::229])
	by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256)
	(Exim 4.84_2)
	(envelope-from <tgl@sss.pgh.pa.us>)
	id 1cW7J8-0001Sk-Rj
	for pgsql-hackers@postgresql.org; Tue, 24 Jan 2017 20:03:11 +0000
Received: from sss.pgh.pa.us ([66.207.139.130])
	by makus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256)
	(Exim 4.84_2)
	(envelope-from <tgl@sss.pgh.pa.us>)
	id 1cW7J5-00079Y-6v
	for pgsql-hackers@postgresql.org; Tue, 24 Jan 2017 20:03:09 +0000
Received: from sss1.sss.pgh.pa.us (localhost [127.0.0.1])
	by sss.pgh.pa.us (8.14.4/8.14.4) with ESMTP id v0OK34Io011457;
	Tue, 24 Jan 2017 15:03:04 -0500
From: Tom Lane <tgl@sss.pgh.pa.us>
To: "Daniel Verite" <daniel@manitou-mail.org>
cc: "Rahila Syed" <rahilasyed90@gmail.com>,
        "Stephen Frost" <sfrost@snowman.net>,
        "Ashutosh Bapat" <ashutosh.bapat@enterprisedb.com>,
        "pgsql-hackers" <pgsql-hackers@postgresql.org>
Subject: Re: Improvements in psql hooks for variables
In-reply-to: <fa2685de-5262-460d-9eca-f027a5de0d7d@manitou-mail.org>
References: <fa2685de-5262-460d-9eca-f027a5de0d7d@manitou-mail.org>
Comments: In-reply-to "Daniel Verite" <daniel@manitou-mail.org>
	message dated "Tue, 24 Jan 2017 17:59:10 +0100"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <11455.1485288184.1@sss.pgh.pa.us>
Date: Tue, 24 Jan 2017 15:03:04 -0500
Message-ID: <11456.1485288184@sss.pgh.pa.us>
X-Pg-Spam-Score: -5.1 (-----)
List-Archive: <http://archives.postgresql.org/pgsql-hackers>
List-Help: <mailto:majordomo@postgresql.org?body=help>
List-ID: <pgsql-hackers.postgresql.org>
List-Owner: <mailto:pgsql-hackers-owner@postgresql.org>
List-Post: <mailto:pgsql-hackers@postgresql.org>
List-Subscribe: <mailto:majordomo@postgresql.org?body=sub%20pgsql-hackers>
List-Unsubscribe: <mailto:majordomo@postgresql.org?body=unsub%20pgsql-hackers>
X-Mailing-List: pgsql-hackers
Precedence: bulk
Sender: pgsql-hackers-owner@postgresql.org

"Daniel Verite" <daniel@manitou-mail.org> writes:
> Here's an update with these changes:

I scanned this patch very quickly and think it addresses my previous
stylistic objections.  Rahila is the reviewer of record though, so
I'll wait for his comments before going further.

			regards, tom lane


-- 
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers