Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtp (Exim 4.80) (envelope-from ) id 1Wg3Zb-0001qL-Dt for pgsql-hackers@arkaria.postgresql.org; Fri, 02 May 2014 02:51:39 +0000 Received: from localhost ([127.0.0.1] helo=postgresql.org) by malur.postgresql.org with smtp (Exim 4.80) (envelope-from ) id 1Wg3Za-0005gP-Hp for pgsql-hackers@arkaria.postgresql.org; Fri, 02 May 2014 02:51:38 +0000 Received: from makus.postgresql.org ([2001:4800:7903:4::125]) by malur.postgresql.org with esmtp (Exim 4.80) (envelope-from ) id 1Wg3ZZ-0005gF-Bp for pgsql-hackers@postgresql.org; Fri, 02 May 2014 02:51:37 +0000 Received: from sss.pgh.pa.us ([66.207.139.130]) by makus.postgresql.org with esmtp (Exim 4.80) (envelope-from ) id 1Wg3ZW-0002SW-U5 for pgsql-hackers@postgresql.org; Fri, 02 May 2014 02:51:36 +0000 Received: from sss1.sss.pgh.pa.us (localhost [127.0.0.1]) by sss.pgh.pa.us (8.14.4/8.14.4) with ESMTP id s422pV7x011464; Thu, 1 May 2014 22:51:31 -0400 From: Tom Lane To: Peter Eisentraut cc: pgsql-hackers Subject: Re: need xmllint on borka In-reply-to: <1398996306.13844.3.camel@vanquo.pezone.net> References: <1398996306.13844.3.camel@vanquo.pezone.net> Comments: In-reply-to Peter Eisentraut message dated "Thu, 01 May 2014 22:05:06 -0400" Date: Thu, 01 May 2014 22:51:31 -0400 Message-ID: <11463.1398999091@sss.pgh.pa.us> X-Pg-Spam-Score: -2.6 (--) List-Archive: List-Help: List-ID: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: X-Mailing-List: pgsql-hackers Precedence: bulk Sender: pgsql-hackers-owner@postgresql.org Peter Eisentraut writes: > I have been working on making the DocBook XML output valid. The first > part was bb4eefe7bf518e42c73797ea37b033a5d8a8e70a, I now have the rest > ready, but I'll spare you the mostly mechanical 200kB patch for now. In > addition, I'd like to add the attached patch with an xmllint call to > make sure things stay valid. > But we don't have xmllint installed on borka, where we build the > releases. Could someone please install it? -1. Doesn't this break "make man" for *any* hacker who doesn't have xmllint installed? Please change the patch so that it runs xmllint if available, rather than turning it into a de facto requirement for anybody who works on documentation. Or if you think you can pass a vote to require it, I'd suggest that the patch had better include documentation additions listing this as a required build tool. (The subtext here is that borka is absolutely not an acceptable place to encounter documentation build failures. By the time we're at that stage of the release cycle, I don't really care what xmllint might have to say; there isn't going to be time to make it happy.) regards, tom lane -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers