From: Tom Lane <tgl@sss.pgh.pa.us>
To: Thomas Munro <thomas.munro@gmail.com>
cc: Tristan Partin <tristan@neon.tech>,
        pgsql-hackers <pgsql-hackers@postgresql.org>
Subject: Re: On non-Windows, hard depend on uselocale(3)
In-reply-to: <CA+hUKGLy2AeE0a6MHq_KQhJXbOQJ6UHsrUoCwb5OGj+WijAWqw@mail.gmail.com>
References: <CWZBBRR6YA8D.8EHMDRGLCKCD@neon.tech> <2689177.1700070346@sss.pgh.pa.us> <CA+hUKGKo7Q4zayx37JxMaD-BzmkaW9j+k70bhA9auN9jztFrVQ@mail.gmail.com> <2946058.1700081498@sss.pgh.pa.us> <CA+hUKGKu7H7iPNQsZ5FcPkZVbgXc5iTBgUjdpM2EHP4q=Tz42Q@mail.gmail.com> <12842.1700083028@sss.pgh.pa.us> <CA+hUKGJ4s6uDK_KYK-2q=2aWztgvTHYqGeSzugaTCEs6_3XqAg@mail.gmail.com> <98824.1700089582@sss.pgh.pa.us> <CA+hUKGLLb1MiqAUwtSb6gQsqm8wgAh+7UEE-6P1tQxjhHCFmrw@mail.gmail.com> <664255.1700245108@sss.pgh.pa.us> <810814.1700261928@sss.pgh.pa.us> <CA+hUKGLy2AeE0a6MHq_KQhJXbOQJ6UHsrUoCwb5OGj+WijAWqw@mail.gmail.com>
Comments: In-reply-to Thomas Munro <thomas.munro@gmail.com>
	message dated "Mon, 20 Nov 2023 11:00:14 +1300"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <1155473.1700433384.1@sss.pgh.pa.us>
Date: Sun, 19 Nov 2023 17:36:24 -0500
Message-ID: <1155474.1700433384@sss.pgh.pa.us>
Archived-At: <https://www.postgresql.org/message-id/1155474.1700433384%40sss.pgh.pa.us>
Precedence: bulk

Thomas Munro <thomas.munro@gmail.com> writes:
> BTW is this comment in snprintf.c true?

>  * 1. No locale support: the radix character is always '.' and the '
>  * (single quote) format flag is ignored.

> It is in the backend but only because we nail down LC_NUMERIC early
> on, not because of any property of snprintf.c, no?

Hmm, the second part of it is true.  But given that we punt float
formatting to libc, I think you are right that the first part
depends on LC_NUMERIC being frozen.

			regards, tom lane