Received: from malur.postgresql.org ([217.196.149.56])
	by arkaria.postgresql.org with esmtps  (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384
	(Exim 4.94.2)
	(envelope-from <pgsql-hackers-owner+archive@lists.postgresql.org>)
	id 1tXtgL-00G3N4-Lo
	for pgsql-hackers@arkaria.postgresql.org; Wed, 15 Jan 2025 03:03:02 +0000
Received: from localhost ([127.0.0.1] helo=malur.postgresql.org)
	by malur.postgresql.org with esmtp (Exim 4.94.2)
	(envelope-from <pgsql-hackers-owner+archive@lists.postgresql.org>)
	id 1tXtgK-006HlY-2y
	for pgsql-hackers@arkaria.postgresql.org; Wed, 15 Jan 2025 03:03:00 +0000
Received: from makus.postgresql.org ([2001:4800:3e1:1::229])
	by malur.postgresql.org with esmtps  (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384
	(Exim 4.94.2)
	(envelope-from <tgl@sss.pgh.pa.us>)
	id 1tXtgJ-006HlQ-Pr
	for pgsql-hackers@lists.postgresql.org; Wed, 15 Jan 2025 03:03:00 +0000
Received: from sss.pgh.pa.us ([68.162.161.243])
	by makus.postgresql.org with esmtps  (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384
	(Exim 4.96)
	(envelope-from <tgl@sss.pgh.pa.us>)
	id 1tXtgJ-000StZ-03
	for pgsql-hackers@lists.postgresql.org;
	Wed, 15 Jan 2025 03:02:59 +0000
Received: from sss1.sss.pgh.pa.us (localhost [127.0.0.1])
	by sss.pgh.pa.us (8.15.2/8.15.2) with ESMTP id 50F32kcj1164439;
	Tue, 14 Jan 2025 22:02:46 -0500
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Nathan Bossart <nathandbossart@gmail.com>
cc: Fujii Masao <masao.fujii@oss.nttdata.com>,
        Andy Fan <zhihuifan1213@163.com>, pgsql-hackers@lists.postgresql.org
Subject: Re: convert libpgport's pqsignal() to a void function
In-reply-to: <Z4chOKfnthRH71mw@nathan>
References: <Z4chOKfnthRH71mw@nathan>
Comments: In-reply-to Nathan Bossart <nathandbossart@gmail.com>
	message dated "Tue, 14 Jan 2025 20:45:12 -0600"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <1164437.1736910166.1@sss.pgh.pa.us>
Date: Tue, 14 Jan 2025 22:02:46 -0500
Message-ID: <1164438.1736910166@sss.pgh.pa.us>
List-Id: <pgsql-hackers.lists.postgresql.org>
List-Help: <https://lists.postgresql.org/manage/>
List-Subscribe: <https://lists.postgresql.org/manage/>
List-Post: <mailto:pgsql-hackers@lists.postgresql.org>
List-Owner: <mailto:pgsql-hackers-owner@lists.postgresql.org>
List-Archive: <https://www.postgresql.org/list/pgsql-hackers>
Archived-At: <https://www.postgresql.org/message-id/1164438.1736910166%40sss.pgh.pa.us>
Precedence: bulk

Nathan Bossart <nathandbossart@gmail.com> writes:
> Thanks to commit 9a45a89, legacy-pqsignal.c now has its own dedicated
> extern for pqsignal(), which decouples it enough that we can follow through
> with changing libpqport's pqsignal() to a void function.

> Thoughts?

LGTM, although I don't know enough about Windows to know if the
"== SIG_ERR" test in that path is correct.

			regards, tom lane