From: Tom Lane <tgl@sss.pgh.pa.us>
To: Robert Haas <robertmhaas@gmail.com>
cc: Jeevan Chalke <jeevan.chalke@enterprisedb.com>,
        PostgreSQL Hackers <pgsql-hackers@postgresql.org>
Subject: Re: Server crash (FailedAssertion) due to catcache refcount
 mis-handling
In-reply-to: 
 <CA+TgmoajwTLHwqobeJM4zYH82uTSo+NXpW8iex3etrz5=8f-Mg@mail.gmail.com>
References: 
 <CAM2+6=VEE30YtRQCZX7_sCFsEpoUkFBV1gZazL70fqLn8rcvBA@mail.gmail.com>
 <4244.1502206577@sss.pgh.pa.us>
 <CA+Tgmob2LxK1vdGmt_nA_B4DW7PzcZoa+Ece4_VihshUvuyoog@mail.gmail.com>
 <6299.1502209596@sss.pgh.pa.us>
 <CA+TgmoYGz7ugdu0=Wf0WJ4fthBLrrWCUfAjGJZoPft=CCeS7rQ@mail.gmail.com>
 <16208.1502224491@sss.pgh.pa.us>
 <CA+TgmobhEYpK97hQuWs8v9Ypgvc=Pjoawk4C4Ue9QLt0zNKzxw@mail.gmail.com>
 <29325.1502246895@sss.pgh.pa.us>
 <CA+TgmoajwTLHwqobeJM4zYH82uTSo+NXpW8iex3etrz5=8f-Mg@mail.gmail.com>
Comments: In-reply-to Robert Haas <robertmhaas@gmail.com>
	message dated "Thu, 10 Aug 2017 13:57:21 -0400"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <11660.1502651113.1@sss.pgh.pa.us>
Date: Sun, 13 Aug 2017 15:05:13 -0400
Message-ID: <11661.1502651113@sss.pgh.pa.us>
Precedence: bulk
Sender: pgsql-hackers-owner@postgresql.org

Robert Haas <robertmhaas@gmail.com> writes:
> On Tue, Aug 8, 2017 at 10:48 PM, Tom Lane <tgl@sss.pgh.pa.us> wrote:
>> Robert Haas <robertmhaas@gmail.com> writes:
>>> On Tue, Aug 8, 2017 at 4:34 PM, Tom Lane <tgl@sss.pgh.pa.us> wrote:
>>>> In the meantime, I think my vote would be to remove AtEOXact_CatCache.

>>> In all supported branches?

>> Whatever we do about this issue, I don't feel a need to do it further
>> back than HEAD.  It's a non-problem except in an assert-enabled build,
>> and we don't recommend running those for production, only development.

> Sure, but people still do testing and development against older
> branches - bug fixes, for example.  It doesn't make much sense to me
> to leave code that we know does the wrong thing in the back branches.

Not having heard anyone arguing against that, I'll go make it so,
ie AtEOXact_CatCache is toast in all branches.

			regards, tom lane


-- 
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers