From: Tom Lane <tgl@sss.pgh.pa.us>
To: Sergey Shinderuk <s.shinderuk@postgrespro.ru>
cc: James Hilliard <james.hilliard1@gmail.com>,
        pgsql-hackers@lists.postgresql.org,
        Thomas Munro <thomas.munro@gmail.com>
Subject: Re: [PATCH 1/1] Fix detection of pwritev support for OSX.
In-reply-to: <6d43a157-e51a-6449-0b47-94d133829afc@postgrespro.ru>
References: <20210119111625.20435-1-james.hilliard1@gmail.com>
 <479372.1611070041@sss.pgh.pa.us>
 <CADvTj4riiHN9Zhhk5qOVndevQMOxuduFbFVVJnCiQ4R7k5_eng@mail.gmail.com>
 <480660.1611071845@sss.pgh.pa.us>
 <CADvTj4o6LEGRJSRR4H8Rmn8r_vv4ZE_mS0MS5Z60NwDZRwdZHQ@mail.gmail.com>
 <483800.1611076636@sss.pgh.pa.us>
 <CADvTj4oD6NoTe78vLi+Ss1CFuPH26vrhUrVTd5DHAPX63vP9Ww@mail.gmail.com>
 <522433.1611089678@sss.pgh.pa.us>
 <CADvTj4qNyMM5vHo+uZ6Xfq5n5g++X_bUTX1-g3zmNXYDWAo8sQ@mail.gmail.com>
 <CADvTj4pucOvo6aWinatLgARs3mjPFSiAXZr2ErSG4ASJsKNxBw@mail.gmail.com>
 <559755.1611106628@sss.pgh.pa.us>
 <CADvTj4qcwzrti9qK8E_xnoPHHn13hWqOGQC-1r3a=Y=mmGvCfQ@mail.gmail.com>
 <791992.1611184078@sss.pgh.pa.us>
 <CADvTj4qJmUdvVw3ECGK_FXXjkTneo5gVJGSvtpDxGrrseQdXDw@mail.gmail.com>
 <915981.1611254324@sss.pgh.pa.us>
 <CADvTj4pzBHOa4PyzLKxZrnOiuwYTa2CDYU=4nUB3Dh8BoReQPg@mail.gmail.com>
 <6d43a157-e51a-6449-0b47-94d133829afc@postgrespro.ru>
Comments: In-reply-to Sergey Shinderuk <s.shinderuk@postgrespro.ru>
	message dated "Fri, 22 Jan 2021 02:32:46 +0300"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <1166795.1611335531.1@sss.pgh.pa.us>
Date: Fri, 22 Jan 2021 12:12:11 -0500
Message-ID: <1166796.1611335531@sss.pgh.pa.us>
Precedence: bulk

Sergey Shinderuk <s.shinderuk@postgrespro.ru> writes:
> I rejected to install CLT and abandoned Homebrew. Then I just cloned and 
> built Postgres successfully. So it looks like Xcode is really enough, at 
> least on a recent macOS version.

Hm.  I seem to recall having had to install CLT as well as Xcode back
in the day, but maybe Apple improved that.  On the other side of the
coin, it also seems to be possible to build PG with only CLT and not
Xcode.  I didn't try to verify that with a scorched-earth test, but
I did trash Xcode (and empty trash) on my wife's Mac, and I could
still build and "make check" with only the CLT in place.

[ pokes more carefully... ]  Ah-hah, I see why I needed the CLT.
I bet you'll find that you can't build from "git clean -dfx" state
with only Xcode, because comparing the contents of
/Applications/Xcode.app/Contents/Developer/usr/bin and
/Library/Developer/CommandLineTools/usr/bin on my own Mac,
I observe that only the CLT provides bison and flex.  I also see
install_name_tool only in the CLT; we don't depend on that today,
but may soon (see the latest thread about coping with SIP).

On the whole it looks like we should recommend installing the CLT
and not bothering with Xcode, which is about 10X the size:

$ du -hs /Library/Developer/CommandLineTools
1.1G    /Library/Developer/CommandLineTools
$ du -hs /Applications/Xcode.app
 15G    /Applications/Xcode.app

			regards, tom lane