Received: from malur.postgresql.org ([217.196.149.56])
	by arkaria.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256)
	(Exim 4.89)
	(envelope-from <pgsql-hackers-owner+archive@lists.postgresql.org>)
	id 1hJ4Kg-0000Rp-Rw
	for pgsql-hackers@arkaria.postgresql.org; Tue, 23 Apr 2019 22:56:11 +0000
Received: from localhost ([127.0.0.1] helo=malur.postgresql.org)
	by malur.postgresql.org with esmtp (Exim 4.89)
	(envelope-from <pgsql-hackers-owner+archive@lists.postgresql.org>)
	id 1hJ4Kf-0004xF-JQ
	for pgsql-hackers@arkaria.postgresql.org; Tue, 23 Apr 2019 22:56:09 +0000
Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29])
	by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256)
	(Exim 4.89)
	(envelope-from <tgl@sss.pgh.pa.us>)
	id 1hJ4Kf-0004x8-BI
	for pgsql-hackers@lists.postgresql.org; Tue, 23 Apr 2019 22:56:09 +0000
Received: from sss.pgh.pa.us ([66.207.139.130])
	by magus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256)
	(Exim 4.89)
	(envelope-from <tgl@sss.pgh.pa.us>)
	id 1hJ4Kd-0002ll-AG
	for pgsql-hackers@postgresql.org; Tue, 23 Apr 2019 22:56:08 +0000
Received: from sss1.sss.pgh.pa.us (localhost [127.0.0.1])
	by sss.pgh.pa.us (8.14.4/8.14.4) with ESMTP id x3NMtg3p011709;
	Tue, 23 Apr 2019 18:55:42 -0400
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Andres Freund <andres@anarazel.de>
cc: Heikki Linnakangas <hlinnaka@iki.fi>,
 Justin Pryzby <pryzby@telsasoft.com>,
        Haribabu Kommi <kommi.haribabu@gmail.com>,
        Kyotaro HORIGUCHI <horiguchi.kyotaro@lab.ntt.co.jp>,
        Alvaro Herrera <alvherre@2ndquadrant.com>,
        David Rowley <david.rowley@2ndquadrant.com>,
        Robert Haas <robertmhaas@gmail.com>, Asim R P <apraveen@pivotal.io>,
        pgsql-hackers@postgresql.org, Ashwin Agrawal <aagrawal@pivotal.io>,
        Dmitry Dolgov <9erthalion6@gmail.com>,
        Alexander Korotkov <a.korotkov@postgrespro.ru>
Subject: Re: Pluggable Storage - Andres's take
In-reply-to: <20190423225201.3bbv6tbqzkb5w7cw@alap3.anarazel.de>
References: <20190312.172757.17614556.horiguchi.kyotaro@lab.ntt.co.jp>
 <CAJrrPGeUqNy0BxWuDd1n5cLQoWUwQ5jhKnDQ6Ty3wt=KsyOoPQ@mail.gmail.com>
 <20190401231810.arpvmhw66bwsyobj@alap3.anarazel.de>
 <CAJrrPGfSEeqdZve2X8zkRo2Bm=M-bQf8WiJEMBshVvtrZjO0Gg@mail.gmail.com>
 <20190402005352.64hk76gddvs36uwl@alap3.anarazel.de>
 <CAJrrPGcB0=UteRJwGMzESdRecc-DUAQBSXfwExmVU1TKwMb5=A@mail.gmail.com>
 <20190402215743.cfiwzlk2szwq4jp3@alap3.anarazel.de>
 <20190404055138.GA24864@telsasoft.com>
 <20190405165101.mosiflz6slokm2oo@alap3.anarazel.de>
 <9a7fb9cc-2419-5db7-8840-ddc10c93f122@iki.fi>
 <20190423225201.3bbv6tbqzkb5w7cw@alap3.anarazel.de>
Comments: In-reply-to Andres Freund <andres@anarazel.de>
	message dated "Tue, 23 Apr 2019 15:52:01 -0700"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <11707.1556060142.1@sss.pgh.pa.us>
Date: Tue, 23 Apr 2019 18:55:42 -0400
Message-ID: <11708.1556060142@sss.pgh.pa.us>
List-Id: <pgsql-hackers.lists.postgresql.org>
List-Help: <https://lists.postgresql.org/manage/>
List-Subscribe: <https://lists.postgresql.org/manage/>
List-Post: <mailto:pgsql-hackers@lists.postgresql.org>
List-Owner: <mailto:pgsql-hackers-owner@lists.postgresql.org>
List-Archive: <https://www.postgresql.org/list/pgsql-hackers>
Precedence: bulk

Andres Freund <andres@anarazel.de> writes:
> ... I think none of these are critical issues for tableam, but we should fix
> them.

> I'm not sure about doing so for v12 though. 1) and 3) are fairly
> trivial, but 2) would involve changing the FDW interface, by changing
> the AnalyzeForeignTable, AcquireSampleRowsFunc signatures. But OTOH,
> we're not even in beta1.

Probably better to fix those API issues now rather than later.

			regards, tom lane