Received: from localhost (maia-4.hub.org [200.46.204.183]) by postgresql.org (Postfix) with ESMTP id A9C039FB395; Fri, 30 Mar 2007 18:28:22 -0300 (ADT) Received: from postgresql.org ([200.46.204.71]) by localhost (mx1.hub.org [200.46.204.183]) (amavisd-maia, port 10024) with ESMTP id 76294-01; Fri, 30 Mar 2007 18:28:18 -0300 (ADT) X-Greylist: from auto-whitelisted by SQLgrey-1.7.4 X-Greylist: from auto-whitelisted by SQLgrey-1.7.4 Received: from mail01.enterprisedb.com (mail01.enterprisedb.com [63.246.7.168]) by postgresql.org (Postfix) with ESMTP id 0751A9FB4D6; Fri, 30 Mar 2007 18:28:18 -0300 (ADT) thread-index: AcdzElzr1FUPTkRVTNG91CAt9TuujQ== Received: from [192.168.0.22] ([85.211.147.35]) by mail01.enterprisedb.com with Microsoft SMTPSVC(6.0.3790.1830); Fri, 30 Mar 2007 17:28:28 -0400 Content-Class: urn:content-classes:message Importance: normal X-MimeOLE: Produced By Microsoft MimeOLE V6.00.3790.2826 Subject: Re: [PATCHES] Full page writes improvement, code update From: "Simon Riggs" To: "Tom Lane" Cc: "Richard Huxton" , "Zeugswetter Andreas ADI SD" , "Koichi Suzuki" , , , In-Reply-To: <23264.1175286950@sss.pgh.pa.us> References: <460886E8.6040907@oss.ntt.co.jp> <4609CAC3.7060008@oss.ntt.co.jp> <1175072848.4386.323.camel@silverbirch.site> <200703291145.28574.josh@agliodbs.com> <1175200117.4386.616.camel@silverbirch.site> <460C611E.6090800@oss.ntt.co.jp> <1175249717.4386.716.camel@silverbirch.site> <460CE5FE.5050906@archonet.com> <1175253689.4386.749.camel@silverbirch.site> <23264.1175286950@sss.pgh.pa.us> Content-Type: text/plain; charset="iso-8859-1" Date: Fri, 30 Mar 2007 22:24:29 +0100 Message-ID: <1175289869.4386.837.camel@silverbirch.site> MIME-Version: 1.0 X-Mailer: Evolution 2.6.0 Content-Transfer-Encoding: 7bit X-OriginalArrivalTime: 30 Mar 2007 21:28:28.0640 (UTC) FILETIME=[5B944E00:01C77312] X-Virus-Scanned: Maia Mailguard 1.0.1 X-Archive-Number: 200703/1801 X-Sequence-Number: 101285 On Fri, 2007-03-30 at 16:35 -0400, Tom Lane wrote: > "Simon Riggs" writes: > > Any page written during a backup has a backup block that would not be > > removable by Koichi's tool, so yes, you'd still be safe. > > How does it know not to do that? Not sure what you mean, but I'll take a stab... I originally questioned Koichi-san's request for a full_page_compress parameter, which is how it would tell whether/not. After explanation, I accepted the need for a parameter, but I think we're looking for a new name for it. -- Simon Riggs EnterpriseDB http://www.enterprisedb.com