Received: from localhost (maia-2.hub.org [200.46.204.187]) by postgresql.org (Postfix) with ESMTP id E65D29FBCCB; Thu, 5 Apr 2007 06:38:48 -0300 (ADT) Received: from postgresql.org ([200.46.204.71]) by localhost (mx1.hub.org [200.46.204.187]) (amavisd-maia, port 10024) with ESMTP id 73783-01; Thu, 5 Apr 2007 06:38:42 -0300 (ADT) X-Greylist: from auto-whitelisted by SQLgrey-1.7.4 X-Greylist: from auto-whitelisted by SQLgrey-1.7.4 Received: from mail01.enterprisedb.com (mail01.enterprisedb.com [63.246.7.168]) by postgresql.org (Postfix) with ESMTP id B995D9FBC55; Thu, 5 Apr 2007 06:38:45 -0300 (ADT) thread-index: Acd3ZjzHZElcY6HKQYqBOsQz21nUOw== Received: from [192.168.0.22] ([85.211.147.35]) by mail01.enterprisedb.com with Microsoft SMTPSVC(6.0.3790.1830); Thu, 5 Apr 2007 05:38:58 -0400 Content-Class: urn:content-classes:message Importance: normal X-MimeOLE: Produced By Microsoft MimeOLE V6.00.3790.2826 Subject: Re: [HACKERS] Full page writes improvement, code update From: "Simon Riggs" To: "Koichi Suzuki" Cc: "Bruce Momjian" , , In-Reply-To: <46123038.6000002@oss.ntt.co.jp> References: <200704022116.l32LGSu15808@momjian.us> <46123038.6000002@oss.ntt.co.jp> Content-Type: text/plain; charset="iso-8859-1" Date: Thu, 05 Apr 2007 10:34:50 +0100 Message-ID: <1175765690.3623.296.camel@silverbirch.site> MIME-Version: 1.0 X-Mailer: Evolution 2.6.0 Content-Transfer-Encoding: 7bit X-OriginalArrivalTime: 05 Apr 2007 09:38:58.0562 (UTC) FILETIME=[3C506620:01C77766] X-Virus-Scanned: Maia Mailguard 1.0.1 X-Archive-Number: 200704/154 X-Sequence-Number: 1721 On Tue, 2007-04-03 at 19:45 +0900, Koichi Suzuki wrote: > Bruce Momjian wrote: > > Your patch has been added to the PostgreSQL unapplied patches list at: > > > > http://momjian.postgresql.org/cgi-bin/pgpatches > > Thank you very much for including. Attached is an update of the patch > according to Simon Riggs's comment about GUC name. The patch comes with its own "install kit", which is great to review (many thanks), but hard to determine where you think code should go when committed. My guess based on your patch - the patch gets applied to core :-) - pg_compresslog *and* pg_decompresslog go to a contrib directory called contrib/lesslog? Can you please produce a combined patch that does all of the above, plus edits the contrib Makefile to add all of those, as well as editing the README so it doesn't mention the patch, just the contrib executables? The patch looks correct to me now. I haven't tested it yet, but will be doing so in the last week of April, which is when I'll be doing docs for this and other stuff, since time is pressing now. -- Simon Riggs EnterpriseDB http://www.enterprisedb.com