public inbox for [email protected]  

help / color / mirror / Atom feed

From: David Christensen <[email protected]>
To: Tom Lane <[email protected]>
Cc: Peter Eisentraut <[email protected]>
Cc: Andrey Borodin <[email protected]>
Cc: pgsql-hackers <[email protected]>
Cc: David G. Johnston <[email protected]>
Cc: Jelte Fennema-Nio <[email protected]>
Subject: Re: [PATCH] GROUP BY ALL
Date: Mon, 29 Sep 2025 16:13:11 -0500
Message-ID: <[email protected]> (raw)
In-Reply-To: <[email protected]>
References: <[email protected]>


> On Sep 29, 2025, at 3:58 PM, Tom Lane <[email protected]> wrote:
> 
> David Christensen <[email protected]> writes:
>>> Here is v7 with a stab at docs; fairly minimal at this point, but
>>> touching the two areas that are likely to need adjusting.
> 
> I did some more word-smithing on the docs and pushed it.
> 
>>> When
>>> adjusting the docs for sql-select, I noticed that the grammar also
>>> supports `GROUP BY ALL <grouping_elements>`, so I also added a test to
>>> ensure that this syntax is explicitly supported.
> 
> +1, can't hurt.
> 
>>> (It seems like it
>>> works as-is without further grammar adjustments, but I was a little
>>> worried when I first saw that fact... :D)
> 
> Bison would have been vocal about it if you'd introduced any
> ambiguity.  Still, I didn't feel like looking around to see if we
> already covered this syntax, and I agree it's close enough to being
> an issue to be worth covering.
> 
> Thanks for the patch!

Great, thank you!

David

view thread (49+ messages)  latest in thread

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected], [email protected], [email protected], [email protected], [email protected]
  Subject: Re: [PATCH] GROUP BY ALL
  In-Reply-To: <[email protected]>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox