From: Tom Lane <tgl@sss.pgh.pa.us>
To: Daniel Gustafsson <daniel@yesql.se>
cc: Alvaro Herrera <alvherre@2ndquadrant.com>,
        Peter Eisentraut <peter.eisentraut@2ndquadrant.com>,
        pgsql-hackers <pgsql-hackers@postgresql.org>
Subject: Re: pgindent vs dtrace on macos
In-reply-to: <B498B70E-C1D7-474B-871B-8B2C35F840FB@yesql.se>
References: <20200917000334.GA28142@alvherre.pgsql>
 <66137.1600303192@sss.pgh.pa.us> <1019914.1600714537@sss.pgh.pa.us>
 <B498B70E-C1D7-474B-871B-8B2C35F840FB@yesql.se>
Comments: In-reply-to Daniel Gustafsson <daniel@yesql.se>
	message dated "Tue, 22 Sep 2020 10:25:54 +0200"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <1177222.1600784320.1@sss.pgh.pa.us>
Content-Transfer-Encoding: quoted-printable
Date: Tue, 22 Sep 2020 10:18:40 -0400
Message-ID: <1177223.1600784320@sss.pgh.pa.us>
Precedence: bulk

Daniel Gustafsson <daniel@yesql.se> writes:
>> On 21 Sep 2020, at 20:55, Tom Lane <tgl@sss.pgh.pa.us> wrote:
>> Here's a proposed patch to fix it that way.

> +1 on this patch.  Do you think it's worth adding a note about this in t=
he
> documentation to save the next one staring at this a few minutes?  Somet=
hing
> along the lines of:

> +If an exported function shares a name with a typedef, the header file w=
ith the
> +prototype can get incorrect spacing for the function.

AFAIK, a function name that's the same as a typedef name will get
misformatted whether it's exported or not; pgindent doesn't really
know the difference.  But yeah, we could add something about this.

			regards, tom lane