Received: from malur.postgresql.org ([217.196.149.56])
	by arkaria.postgresql.org with esmtp (Exim 4.72) (envelope-from
	<pgsql-hackers-owner+M220638=pgsql-hackers-arkari@postgresql.org>)
	id 1TwH9z-0003ib-Uk for pgsql-hackers@arkaria.postgresql.org;
	Fri, 18 Jan 2013 18:59:28 +0000
Received: from localhost ([127.0.0.1] helo=postgresql.org)
	by malur.postgresql.org with smtp (Exim 4.72) (envelope-from
	<pgsql-hackers-owner+M220638=pgsql-hackers-arkari@postgresql.org>)
	id 1TwH9y-0005MZ-P6 for pgsql-hackers@arkaria.postgresql.org;
	Fri, 18 Jan 2013 18:59:26 +0000
Received: from makus.postgresql.org ([98.129.198.125])
	by malur.postgresql.org with esmtp (Exim 4.72)
	(envelope-from <tgl@sss.pgh.pa.us>) id 1TwH9x-0005MT-A1
	for pgsql-hackers@postgresql.org; Fri, 18 Jan 2013 18:59:25 +0000
Received: from sss.pgh.pa.us ([66.207.139.130])
	by makus.postgresql.org with esmtp (Exim 4.72)
	(envelope-from <tgl@sss.pgh.pa.us>) id 1TwH9t-00012Y-UQ
	for pgsql-hackers@postgresql.org; Fri, 18 Jan 2013 18:59:24 +0000
Received: from sss2.sss.pgh.pa.us (tgl@localhost [127.0.0.1])
	by sss.pgh.pa.us (8.14.5/8.14.5) with ESMTP id r0IIxHla011783;
	Fri, 18 Jan 2013 13:59:17 -0500 (EST)
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Alvaro Herrera <alvherre@2ndquadrant.com>
cc: Andres Freund <andres@2ndquadrant.com>,
	Robert Haas <robertmhaas@gmail.com>,
	Dimitri Fontaine <dimitri@2ndquadrant.fr>,
	Simon Riggs <simon@2ndquadrant.com>,
	PostgreSQL Hackers <pgsql-hackers@postgresql.org>
Subject: Re: Event Triggers: adding information
In-reply-to: <20130118182255.GG4063@alvh.no-ip.org>
References: <m2ehhjbf48.fsf@2ndQuadrant.fr>
	<20130118013334.GE3074@awork2.anarazel.de>
	<CA+TgmobU2xZ7hPh24HYmvSxO7kbXUtY57bePX+mpB5aywTz2HA@mail.gmail.com>
	<20130118140721.GA29501@alap2.anarazel.de>
	<CA+TgmoYL9o2MBjWdaUcRqj_B5J=k63rq8vKkcszDyH4CDT1AKQ@mail.gmail.com>
	<20130118154732.GE29501@alap2.anarazel.de>
	<CA+Tgmoa-p-texRBzgetFgvaKwWJJ=a3XBCWMOQdg17aWtrDPNg@mail.gmail.com>
	<20130118170857.GK29501@alap2.anarazel.de>
	<10183.1358531053@sss.pgh.pa.us>
	<20130118180326.GM29501@alap2.anarazel.de>
	<20130118182255.GG4063@alvh.no-ip.org>
Comments: In-reply-to Alvaro Herrera <alvherre@2ndquadrant.com>
	message dated "Fri, 18 Jan 2013 15:22:55 -0300"
Date: Fri, 18 Jan 2013 13:59:17 -0500
Message-ID: <11782.1358535557@sss.pgh.pa.us>
X-Pg-Spam-Score: -1.9 (-)
List-Archive: <http://archives.postgresql.org/pgsql-hackers>
List-Help: <mailto:majordomo@postgresql.org?body=help>
List-ID: <pgsql-hackers.postgresql.org>
List-Owner: <mailto:pgsql-hackers-owner@postgresql.org>
List-Post: <mailto:pgsql-hackers@postgresql.org>
List-Subscribe: <mailto:majordomo@postgresql.org?body=sub%20pgsql-hackers>
List-Unsubscribe: <mailto:majordomo@postgresql.org?body=unsub%20pgsql-hackers>
X-Mailing-List: pgsql-hackers
Precedence: bulk
Sender: pgsql-hackers-owner@postgresql.org

Alvaro Herrera <alvherre@2ndquadrant.com> writes:
> Andres Freund escribió:
>> Dimitri's earlier patches had support for quite some commands via
>> deparsing and while its a noticeable amount of code it seemed to work
>> ok.
>> The last revision I could dig out is
>> https://github.com/dimitri/postgres/blob/d2996303c7bc6daa08cef23e3d5e07c3afb11191/src/backend/utils/adt/ddl_rewrite.c

> I looked at that code back then and didn't like it very much.  The
> problem I see (as Robert does, I think) is that it raises the burden
> when you change the grammar -- you now need to edit not only gram.y, but
> the ddl_rewrite.c stuff to ensure your new thing can be reverse-parsed.

Well, that burden already exists for non-utility statements --- why
should utility statements get a pass?  Other than that we tend to invent
new utility syntax freely, which might be a good thing to discourage
anyhow.

			regards, tom lane


-- 
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers