Received: from localhost (maia-3.hub.org [200.46.204.184]) by postgresql.org (Postfix) with ESMTP id 5127E9FB593 for ; Mon, 28 May 2007 17:50:34 -0300 (ADT) Received: from postgresql.org ([200.46.204.71]) by localhost (mx1.hub.org [200.46.204.184]) (amavisd-maia, port 10024) with ESMTP id 02021-01 for ; Mon, 28 May 2007 17:50:19 -0300 (ADT) X-Greylist: from auto-whitelisted by SQLgrey-1.7.4 Received: from [66.135.97.2] (wmqhotel.2.ADSL.NetSurf.Net [66.135.97.2]) by postgresql.org (Postfix) with ESMTP id 065619FB26F for ; Mon, 28 May 2007 17:50:21 -0300 (ADT) Received: from [192.168.123.112] ([10.1.251.249]) by [66.135.97.2] (8.13.6/8.13.6) with ESMTP id l4SKoWs3022627; Mon, 28 May 2007 16:50:32 -0400 Subject: Re: Logging checkpoints and other slowdown causes From: Simon Riggs To: Heikki Linnakangas Cc: Greg Smith , pgsql-patches@postgresql.org In-Reply-To: <465B3ABB.6010709@enterprisedb.com> References: <200704030814.33999.peter_e@gmx.net> <46443F02.6060300@enterprisedb.com> <465B3ABB.6010709@enterprisedb.com> Content-Type: text/plain Date: Mon, 28 May 2007 21:48:39 +0100 Message-Id: <1180385320.26297.17.camel@silverbirch.site> Mime-Version: 1.0 X-Mailer: Evolution 2.6.0 Content-Transfer-Encoding: 7bit X-Virus-Scanned: Maia Mailguard 1.0.1 X-Archive-Number: 200705/458 X-Sequence-Number: 2558 On Mon, 2007-05-28 at 21:25 +0100, Heikki Linnakangas wrote: > - RequestCheckpoint and CreateCheckpoint was changed to take a > CheckpointReason enum as argument, instead of boolean flags. This allows > printing a different message depending on the cause of checkpoint, and > is also cleaner IMHO. Looks good. I'd be inclined to make the reason code for creating/dropping database the same and just say "Cluster DDL" or something, since for analysis purposes we just want to know it was DDL. I'd rather see the timings in seconds rather than ms. Counting significant digits will be a pain... -- Simon Riggs EnterpriseDB http://www.enterprisedb.com