Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1peDDZ-0000Ha-Dq for pgsql-hackers@arkaria.postgresql.org; Mon, 20 Mar 2023 10:58:21 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1peDDY-0004JI-8D for pgsql-hackers@arkaria.postgresql.org; Mon, 20 Mar 2023 10:58:20 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1peDDX-0004J9-UR for pgsql-hackers@lists.postgresql.org; Mon, 20 Mar 2023 10:58:19 +0000 Received: from new4-smtp.messagingengine.com ([66.111.4.230]) by magus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1peDDQ-00060U-Lv for pgsql-hackers@postgresql.org; Mon, 20 Mar 2023 10:58:19 +0000 Received: from compute6.internal (compute6.nyi.internal [10.202.2.47]) by mailnew.nyi.internal (Postfix) with ESMTP id F2519582099; Mon, 20 Mar 2023 06:58:10 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute6.internal (MEProxy); Mon, 20 Mar 2023 06:58:10 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:sender:subject:subject:to:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; t= 1679309890; x=1679317090; bh=wRwgFSgPWxK3UgM1aE2e7QFWlEmAOe1n9aa KjeZW+xw=; b=T3KPXo+4jHuelWkTSudwQ6DKbm/FV5C/flWwjAq+GZ1yzI93mRk f8PxaP864k4jsWAafvB0I6dEn02BjFa+aW/2QmLYwVp7az/WG5ul2pnO0XA7emn7 GfGObdJzONYV+YBPQUunH7sWARZNHot44QSB8VOo5pJu/L3kUT2/W9AGNjtFddhY 0bFmDkOXbk7skdy+nEmLWuZ3QyHxK/RlGnzvPTk0qktjhOKQKvlE99U4mwsk2ttb AiZT42mvg1cDKE0xAgam4y66jdTzfyWxyxNo2b1/nN4RAlaXugQsxMRZoytqrwEL jTPutRXGCYYEvgDWthiwya/+OmveSiu4DAg== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvhedrvdefkedgvdduucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepkfffgggfuffvvehfhfgjtgfgsehtjeertddtfeejnecuhfhrohhmpefrvght vghrucfgihhsvghnthhrrghuthcuoehpvghtvghrrdgvihhsvghnthhrrghuthesvghnth gvrhhprhhishgvuggsrdgtohhmqeenucggtffrrghtthgvrhhnpeehleffgeegudejteei hfelteduvdeifffhffdvjedvffegjeekudeludehudeifeenucevlhhushhtvghrufhiii gvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehpvghtvghrrdgvihhsvghnthhrrghu thesvghnthgvrhhprhhishgvuggsrdgtohhm X-ME-Proxy: Feedback-ID: i131946ab:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Mon, 20 Mar 2023 06:58:10 -0400 (EDT) Message-ID: <1181e72c-0f9b-b2d5-b63f-48adeb9aee5b@enterprisedb.com> Date: Mon, 20 Mar 2023 11:58:08 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.9.0 Subject: Re: meson documentation build open issues Content-Language: en-US To: Andres Freund Cc: pgsql-hackers References: <3fc3bb9b-f7f8-d442-35c1-ec82280c564a@enterprisedb.com> <20230316035533.ttzrntt4pwbmwrys@awork3.anarazel.de> <20230320023338.hiclf2hcoxlzizdg@awork3.anarazel.de> From: Peter Eisentraut In-Reply-To: <20230320023338.hiclf2hcoxlzizdg@awork3.anarazel.de> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk On 20.03.23 03:33, Andres Freund wrote: >> I did end up getting stuck when hacking on this, and ended up adding css >> support for nochunk and support for the website style for htmlhelp and >> nochunk, as well as obsoleting the need for copying the css files... But >> perhaps that's a bit too much. > Updated set of patches attached. This one works in older meson versions too > and adds install-world and install-quiet targets. Oh, this patch set grew quite quickly. ;-) [PATCH v2 1/8] meson: rename html_help target to htmlhelp This is obvious. [PATCH v2 5/8] docs: html: copy images to output as part of xslt build Making the XSLT stylesheets do the copying has some appeal. I think it would only work for SVG (or other XML) files, which I guess is okay, but maybe the templates should have a filter on format="SVG" or something. Also, this copying actually modifies the files in some XML-equivalent way. Also okay, I think, but worth noting. Note sure why you removed this comment - since the code still exists. [PATCH v2 6/8] wip: docs: copy or inline css This seems pretty complicated compared to just copying a file?