From: Antonin Houska <ah@cybertec.at>
To: Toshi Harada <harada.toshi@po.ntt-tx.co.jp>
cc: pgsql-hackers@postgresql.org
Subject: Re: "WIP: Data at rest encryption" patch and, 2 phase commit.
In-reply-to: <201807230637.w6N6bDnQ028675@ccmail04.silk.ntt-tx.co.jp>
References: <1248.1530086523@localhost>
 <201807230637.w6N6bDnQ028675@ccmail04.silk.ntt-tx.co.jp>
Comments: In-reply-to Toshi Harada <harada.toshi@po.ntt-tx.co.jp>
   message dated "Mon, 23 Jul 2018 15:36:40 +0900."
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Date: Wed, 25 Jul 2018 13:54:22 +0200
Message-ID: <11824.1532519662@localhost>
Precedence: bulk

Toshi Harada <harada.toshi@po.ntt-tx.co.jp> wrote:

> Hi.
>=20
> I applied the patch "WIP: Data at rest encryption" to PostgreSQL 11 - bet=
a 2 and I'm working on it.
>=20
> When this patch is applied, the following problem occurs.
>=20
> * An error occurs when CHECKPOINT is executed during two-phase commit.
> * After an error occurs, if you stop PostgreSQL, it will never start agai=
n.
>=20
> (1) First, execute PREPARE TRANSACTION.
>=20
> postgres=3D# BEGIN;
> BEGIN
> postgres=3D# PREPARE TRANSACTION 'foo';
> PREPARE TRANSACTION
> postgres=3D#
>=20
> (2) Execute the CHECKPOINT command from another terminal.
>     CHEKPOINT command fails.
>=20
> postgres=3D# CHECKPOINT;
> ERROR:  checkpoint request failed
> HINT:  Consult recent messages in the server log for details.
> postgres=3D#

The patch version I posted in

https://www.postgresql.org/message-id/11678.1532519255%40localhost

fixes an issue (unitialized pointer) that caused failure here, but it was
SEGFAULT rather than ERROR. And the scope of the bug was broader than just
CHECKPOINT.

Can you please test it again with the new version of the patch?

Anyway, thanks for your reports!


--=20
Antonin Houska
Cybertec Sch=C3=B6nig & Sch=C3=B6nig GmbH
Gr=C3=B6hrm=C3=BChlgasse 26, A-2700 Wiener Neustadt
Web: https://www.cybertec-postgresql.com