Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1hSitU-0000Ib-Dt for pgsql-hackers@arkaria.postgresql.org; Mon, 20 May 2019 14:04:00 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.89) (envelope-from ) id 1hSitT-00034I-3Q for pgsql-hackers@arkaria.postgresql.org; Mon, 20 May 2019 14:03:59 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1hSitS-00034B-Qw for pgsql-hackers@lists.postgresql.org; Mon, 20 May 2019 14:03:58 +0000 Received: from mx2.mailbox.org ([80.241.60.215]) by magus.postgresql.org with esmtps (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1hSitP-0007HN-41 for pgsql-hackers@postgresql.org; Mon, 20 May 2019 14:03:58 +0000 Received: from smtp2.mailbox.org (smtp2.mailbox.org [80.241.60.241]) (using TLSv1.2 with cipher ECDHE-RSA-CHACHA20-POLY1305 (256/256 bits)) (No client certificate requested) by mx2.mailbox.org (Postfix) with ESMTPS id 31662A0146 for ; Mon, 20 May 2019 16:03:53 +0200 (CEST) X-Virus-Scanned: amavisd-new at heinlein-support.de Received: from smtp2.mailbox.org ([80.241.60.241]) by spamfilter05.heinlein-hosting.de (spamfilter05.heinlein-hosting.de [80.241.56.123]) (amavisd-new, port 10030) with ESMTP id kcvoQP-CzR0b for ; Mon, 20 May 2019 16:03:44 +0200 (CEST) From: Antonin Houska To: pgsql-hackers@postgresql.org Subject: Inaccurate header comment of issue_xlog_fsync_comment MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" Date: Mon, 20 May 2019 16:03:40 +0200 Message-ID: <11863.1558361020@spoje.net> List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk --=-=-= Content-Type: text/plain Someone probably forgot to update the comment when changing the arguments. -- Antonin Houska Web: https://www.cybertec-postgresql.com --=-=-= Content-Type: text/x-diff Content-Disposition: attachment; filename=issue_xlog_fsync_comment.patch diff --git a/src/backend/access/transam/xlog.c b/src/backend/access/transam/xlog.c index c00b63c751..527522f165 100644 --- a/src/backend/access/transam/xlog.c +++ b/src/backend/access/transam/xlog.c @@ -10065,7 +10065,7 @@ assign_xlog_sync_method(int new_sync_method, void *extra) * Issue appropriate kind of fsync (if any) for an XLOG output file. * * 'fd' is a file descriptor for the XLOG file to be fsync'd. - * 'log' and 'seg' are for error reporting purposes. + * 'segno' is for error reporting purposes. */ void issue_xlog_fsync(int fd, XLogSegNo segno) --=-=-=--