From: Tom Lane <tgl@sss.pgh.pa.us>
To: Justin Pryzby <pryzby@telsasoft.com>
cc: Fabien COELHO <coelho@cri.ensmp.fr>, pgsql-hackers@postgresql.org,
        Alvaro Herrera <alvherre@2ndquadrant.com>,
        David Steele <david@pgmasters.net>,
        "Bossart,
    Nathan" <bossartn@amazon.com>,
        Thomas Munro <thomas.munro@gmail.com>
Subject: Re: pg11+: pg_ls_*dir LIMIT 1: temporary files .. not closed at
 end-of-transaction
In-reply-to: <20200331080643.GE14618@telsasoft.com>
References: <24244.1585415634@sss.pgh.pa.us>
 <20200328183904.GI20103@telsasoft.com> <28906.1585422475@sss.pgh.pa.us>
 <27064.1585499825@sss.pgh.pa.us> <20200329171415.GL20103@telsasoft.com>
 <29512.1585502524@sss.pgh.pa.us> <20200329201215.GM20103@telsasoft.com>
 <alpine.DEB.2.21.2003300704430.16227@pseudo> <4028.1585579463@sss.pgh.pa.us>
 <alpine.DEB.2.21.2003310723560.16227@pseudo>
 <20200331080643.GE14618@telsasoft.com>
Comments: In-reply-to Justin Pryzby <pryzby@telsasoft.com>
	message dated "Tue, 31 Mar 2020 03:06:43 -0500"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <11881.1585672910.1@sss.pgh.pa.us>
Content-Transfer-Encoding: quoted-printable
Date: Tue, 31 Mar 2020 12:41:50 -0400
Message-ID: <11882.1585672910@sss.pgh.pa.us>
Precedence: bulk

Justin Pryzby <pryzby@telsasoft.com> writes:
> I suggest to leave stat() alone in your patch for stable releases.  I th=
ink
> it's okay if we change behavior so that a broken symlink is skipped inst=
ead of
> erroring (as a side effect of skipping ENOENT with stat()).  But not oka=
y if we
> change pg_ls_logdir() to hide symlinks in back braches.

Meh.  I'm not really convinced, but in the absence of anyone expressing
support for my position, I'll do it that way.  I don't think it's worth
doing both a stat and lstat to tell the difference between file-is-gone
and file-is-a-broken-symlink.

			regards, tom lane