Content-Type: multipart/mixed; boundary="------------ZLH2J4GYaYzdNrKLyH0LlsLy"
Message-ID: <118ca69e-47eb-42e1-83e9-72ccf40dd6fd@proxel.se>
Date: Tue, 14 Apr 2026 02:20:25 +0200
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: Speed up ICU case conversion by using ucasemap_utf8To*()
To: Jeff Davis <pgsql@j-davis.com>, Alexander Lakhin <exclusion@gmail.com>,
 zengman <zengman@halodbtech.com>,
 pgsql-hackers <pgsql-hackers@postgresql.org>
References: <167986ff-afcf-4542-94c6-61ee8474e138@proxel.se>
 <72c7c2b5848da44caddfe0f20f6c7ebc7c0c6e60.camel@j-davis.com>
 <c380cf11-dd23-4a75-af3e-3da8ec88bf6c@proxel.se>
 <tencent_32015AAF279D4D696813121C@qq.com>
 <4cfde442-25dd-495f-8d76-a23502ce17b8@proxel.se>
 <744b9998-4463-4be5-b60e-a960eeb43202@proxel.se>
 <tencent_3C4ABC775EDA640F219A5E69@qq.com>
 <5a010b27-8ed9-4739-86fe-1562b07ba564@proxel.se>
 <cca5b4a19d68e4488ffab1f41b222a7b4c60468f.camel@j-davis.com>
 <96d80a47-f17f-42fa-82b1-2908efbd6541@gmail.com>
 <dcea4840-18d0-4b5f-af16-1baefc563a3d@proxel.se>
 <84006e443ef2dcfcbff8dcb3814c0c402b8ff7fd.camel@j-davis.com>
Content-Language: en-US
From: Andreas Karlsson <andreas@proxel.se>
In-Reply-To: <84006e443ef2dcfcbff8dcb3814c0c402b8ff7fd.camel@j-davis.com>
Archived-At: 
 <https://www.postgresql.org/message-id/118ca69e-47eb-42e1-83e9-72ccf40dd6fd%40proxel.se>
Precedence: bulk

This is a multi-part message in MIME format.
--------------ZLH2J4GYaYzdNrKLyH0LlsLy
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit

On 4/13/26 20:40, Jeff Davis wrote:
> Thank you both!

Thanks!

> Committed with minor revisions:
> 
> * also check the status code, just to be sure

If we do that shouldn't we also do the same in the other callsites in 
initdb.c uloc_getLanguage()? Maybe something like the attached. Also I 
wonder if maybe other ICU functions have the same risk.

Andreas

--------------ZLH2J4GYaYzdNrKLyH0LlsLy
Content-Type: text/x-patch; charset=UTF-8;
 name="v1-0001-Always-check-for-untermianted-strings-when-callin.patch"
Content-Disposition: attachment;
 filename*0="v1-0001-Always-check-for-untermianted-strings-when-callin.pa";
 filename*1="tch"
Content-Transfer-Encoding: base64

RnJvbSA4NjcwM2NhZTYyN2YyZDFhMTJmZWNiM2E2YWI3ZmJjMGYwNTExMzMwIE1vbiBTZXAg
MTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBBbmRyZWFzIEthcmxzc29uIDxhbmRyZWFzLmthcmxz
c29uQHBlcmNvbmEuY29tPgpEYXRlOiBUdWUsIDE0IEFwciAyMDI2IDAyOjEyOjE1ICswMjAw
ClN1YmplY3Q6IFtQQVRDSCB2MV0gQWx3YXlzIGNoZWNrIGZvciB1bnRlcm1pYW50ZWQgc3Ry
aW5ncyB3aGVuIGNhbGxpbmcKIHVsb2NfZ2V0TGFuZ3VhZ2UoKQoKLS0tCiBzcmMvYmluL2lu
aXRkYi9pbml0ZGIuYyB8IDQgKystLQogMSBmaWxlIGNoYW5nZWQsIDIgaW5zZXJ0aW9ucygr
KSwgMiBkZWxldGlvbnMoLSkKCmRpZmYgLS1naXQgYS9zcmMvYmluL2luaXRkYi9pbml0ZGIu
YyBiL3NyYy9iaW4vaW5pdGRiL2luaXRkYi5jCmluZGV4IDUwOWYxMTE0ZWY2Li4yMWYyNTkx
NWFiMiAxMDA2NDQKLS0tIGEvc3JjL2Jpbi9pbml0ZGIvaW5pdGRiLmMKKysrIGIvc3JjL2Jp
bi9pbml0ZGIvaW5pdGRiLmMKQEAgLTI0MDMsNyArMjQwMyw3IEBAIGljdV92YWxpZGF0ZV9s
b2NhbGUoY29uc3QgY2hhciAqbG9jX3N0cikKIAkvKiB2YWxpZGF0ZSB0aGF0IHdlIGNhbiBl
eHRyYWN0IHRoZSBsYW5ndWFnZSAqLwogCXN0YXR1cyA9IFVfWkVST19FUlJPUjsKIAl1bG9j
X2dldExhbmd1YWdlKGxvY19zdHIsIGxhbmcsIFVMT0NfTEFOR19DQVBBQ0lUWSwgJnN0YXR1
cyk7Ci0JaWYgKFVfRkFJTFVSRShzdGF0dXMpKQorCWlmIChVX0ZBSUxVUkUoc3RhdHVzKSB8
fCBzdGF0dXMgPT0gVV9TVFJJTkdfTk9UX1RFUk1JTkFURURfV0FSTklORykKIAl7CiAJCXBn
X2ZhdGFsKCJjb3VsZCBub3QgZ2V0IGxhbmd1YWdlIGZyb20gbG9jYWxlIFwiJXNcIjogJXMi
LAogCQkJCSBsb2Nfc3RyLCB1X2Vycm9yTmFtZShzdGF0dXMpKTsKQEAgLTI0MjMsNyArMjQy
Myw3IEBAIGljdV92YWxpZGF0ZV9sb2NhbGUoY29uc3QgY2hhciAqbG9jX3N0cikKIAogCQlz
dGF0dXMgPSBVX1pFUk9fRVJST1I7CiAJCXVsb2NfZ2V0TGFuZ3VhZ2Uob3RoZXJsb2MsIG90
aGVybGFuZywgVUxPQ19MQU5HX0NBUEFDSVRZLCAmc3RhdHVzKTsKLQkJaWYgKFVfRkFJTFVS
RShzdGF0dXMpKQorCQlpZiAoVV9GQUlMVVJFKHN0YXR1cykgfHwgc3RhdHVzID09PSBVX1NU
UklOR19OT1RfVEVSTUlOQVRFRF9XQVJOSU5HKQogCQkJY29udGludWU7CiAKIAkJaWYgKHN0
cmNtcChsYW5nLCBvdGhlcmxhbmcpID09IDApCi0tIAoyLjQzLjAKCg==

--------------ZLH2J4GYaYzdNrKLyH0LlsLy--