From: Tom Lane <tgl@sss.pgh.pa.us>
To: Artur Zakirov <a.zakirov@postgrespro.ru>
cc: Andreas Seltenreich <seltenreich@gmx.de>,
        pgsql-hackers <pgsql-hackers@postgresql.org>
Subject: Re: [sqlsmith] Crash in tsquery_rewrite/QTNBinary
In-reply-to: 
 <CAKNkYnyD=u+wVreeg+5shFa==PstJFboZY3rUBbynZE5y8WpzA@mail.gmail.com>
References: <8737i01dew.fsf@credativ.de>
 <CAKNkYnyD=u+wVreeg+5shFa==PstJFboZY3rUBbynZE5y8WpzA@mail.gmail.com>
Comments: In-reply-to Artur Zakirov <a.zakirov@postgrespro.ru>
	message dated "Sun, 11 Dec 2016 00:07:25 +0300"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <11904.1481479944.1@sss.pgh.pa.us>
Date: Sun, 11 Dec 2016 13:12:24 -0500
Message-ID: <11905.1481479944@sss.pgh.pa.us>
Precedence: bulk
Sender: pgsql-hackers-owner@postgresql.org

Artur Zakirov <a.zakirov@postgrespro.ru> writes:
> 2016-12-07 9:06 GMT+03:00 Andreas Seltenreich <seltenreich@gmx.de>:
>> the following query crashes master as of 4212cb7.

> It happens because 'I' is stop word and substitute query becomes
> empty. And for queries above we need recursive dropvoidsubtree()
> function. Without this patch this function cleans only first level of
> tree. And query above becomes: '6 | void'.

> Firstly I made recursive dropvoidsubtree(). But attached patch cleans
> query tree in dofindsubquery() to avoid extra tree scan.

This patch looks good to me.  I have to admit that I'd been suspicious
of dropvoidsubtree() the last time I looked at this code, but I didn't
have adequate reason to touch it.  Pushed with some minor comment
adjustments.

			regards, tom lane


-- 
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers