Received: from malur.postgresql.org ([217.196.149.56])
	by arkaria.postgresql.org with esmtps
 (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256)
	(Exim 4.89)
	(envelope-from <pgsql-hackers-owner+archive@lists.postgresql.org>)
	id 1eqk7e-0004AS-Ai
	for pgsql-hackers@arkaria.postgresql.org; Tue, 27 Feb 2018 18:37:06 +0000
Received: from localhost ([127.0.0.1] helo=malur.postgresql.org)
	by malur.postgresql.org with esmtp (Exim 4.89)
	(envelope-from <pgsql-hackers-owner+archive@lists.postgresql.org>)
	id 1eqk7d-0000dE-B2
	for pgsql-hackers@arkaria.postgresql.org; Tue, 27 Feb 2018 18:37:05 +0000
Received: from makus.postgresql.org ([2001:4800:1501:1::229])
	by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256)
	(Exim 4.89)
	(envelope-from <tgl@sss.pgh.pa.us>)
	id 1eqk7d-0000d5-0p
	for pgsql-hackers@lists.postgresql.org; Tue, 27 Feb 2018 18:37:05 +0000
Received: from sss.pgh.pa.us ([66.207.139.130])
	by makus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256)
	(Exim 4.89)
	(envelope-from <tgl@sss.pgh.pa.us>)
	id 1eqk7Z-00025O-Oo
	for pgsql-hackers@lists.postgresql.org; Tue, 27 Feb 2018 18:37:03 +0000
Received: from sss1.sss.pgh.pa.us (localhost [127.0.0.1])
	by sss.pgh.pa.us (8.14.4/8.14.4) with ESMTP id w1RIaxun011928;
	Tue, 27 Feb 2018 13:36:59 -0500
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Andrew Dunstan <andrew@dunslane.net>
cc: pgsql-hackers@lists.postgresql.org
Subject: Sigh, I broke crake again
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <11926.1519756619.1@sss.pgh.pa.us>
Date: Tue, 27 Feb 2018 13:36:59 -0500
Message-ID: <11927.1519756619@sss.pgh.pa.us>
List-Id: <pgsql-hackers.lists.postgresql.org>
List-Help: <https://lists.postgresql.org/manage/>
List-Subscribe: <https://lists.postgresql.org/manage/>
List-Post: <mailto:pgsql-hackers@lists.postgresql.org>
List-Owner: <mailto:pgsql-hackers-owner@lists.postgresql.org>
List-Archive: <https://www.postgresql.org/list/pgsql-hackers>
Precedence: bulk

I just committed some regression test cleanup that removed or renamed
a couple of C-language functions in regress.so.  I see that crake is
now failing XversionUpgrade tests, and although I can't see the details,
I bet the problem is from trying to load CREATE FUNCTION commands from
the old regression databases that now don't point to an existing C
function.

Does it seem practical to adjust TestUpgradeXversion.pm to cope with
this change?  An alternative answer is to put back C-language stubs
in regress.c for the removed functions, but that seems a bit grotty.

			regards, tom lane