Received: from malur.postgresql.org ([2a02:16a8:dc51::56]) by arkaria.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.89) (envelope-from ) id 1fkcaA-0000lF-HP for pgsql-hackers@arkaria.postgresql.org; Tue, 31 Jul 2018 21:53:30 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.89) (envelope-from ) id 1fkca7-0001Nc-Kp for pgsql-hackers@arkaria.postgresql.org; Tue, 31 Jul 2018 21:53:27 +0000 Received: from makus.postgresql.org ([2001:4800:1501:1::229]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.89) (envelope-from ) id 1fkca7-0001NV-7H for pgsql-hackers@lists.postgresql.org; Tue, 31 Jul 2018 21:53:27 +0000 Received: from sss.pgh.pa.us ([66.207.139.130]) by makus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.89) (envelope-from ) id 1fkca4-000214-An for pgsql-hackers@postgresql.org; Tue, 31 Jul 2018 21:53:25 +0000 Received: from sss1.sss.pgh.pa.us (localhost [127.0.0.1]) by sss.pgh.pa.us (8.14.4/8.14.4) with ESMTP id w6VLrJxE011979; Tue, 31 Jul 2018 17:53:20 -0400 From: Tom Lane To: Peter Geoghegan cc: Andres Freund , Andrew Gierth , PostgreSQL Hackers Subject: Re: Should contrib modules install .h files? In-reply-to: References: <87h8lhoevw.fsf@news-spur.riddles.org.uk> <63819.1530544945@sss.pgh.pa.us> <878t6to8j9.fsf@news-spur.riddles.org.uk> <874lhho071.fsf@news-spur.riddles.org.uk> <67427.1530738056@sss.pgh.pa.us> <87po02m0bh.fsf@news-spur.riddles.org.uk> <87in5tnafh.fsf@news-spur.riddles.org.uk> <87efghn7js.fsf@news-spur.riddles.org.uk> <87a7r5n4n2.fsf@news-spur.riddles.org.uk> <87o9enb4h7.fsf@news-spur.riddles.org.uk> <20180731201700.zfscje7clxiljvjl@alap3.anarazel.de> Comments: In-reply-to Peter Geoghegan message dated "Tue, 31 Jul 2018 13:22:27 -0700" MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <11977.1533073999.1@sss.pgh.pa.us> Date: Tue, 31 Jul 2018 17:53:19 -0400 Message-ID: <11978.1533073999@sss.pgh.pa.us> List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk Peter Geoghegan writes: > On Tue, Jul 31, 2018 at 1:17 PM, Andres Freund wrote: >> I'm a bit surprised that you decided to push to the 11 branch - the >> consensus in this thread seem to have gone the other way by my read? >> Given that that's the rule, and pushing non-fixes is the exception, I'm >> not particularly ok with just ignoring that? > +1 By my count of people expressing opinions, we had Michael -1, Stephen -1, me -0.1 or so, Alvaro +1, Peter -1, presumably +1 from Andrew; and Andres made a comment about not waiting, which perhaps Andrew read as a +1 for backpatching. So it's not unreasonable for Andrew to have decided that it was about tied. Nonetheless, it does seem like a feature and we're past feature freeze, so the default assumption ought to be "no backpatch" IMO. regards, tom lane