Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1v4I8b-00CKeP-2t for pgsql-hackers@arkaria.postgresql.org; Thu, 02 Oct 2025 12:10:21 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.94.2) (envelope-from ) id 1v4I8Z-007SlM-3h for pgsql-hackers@arkaria.postgresql.org; Thu, 02 Oct 2025 12:10:19 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1v4I8Y-007SlD-Ci for pgsql-hackers@lists.postgresql.org; Thu, 02 Oct 2025 12:10:19 +0000 Received: from fhigh-a2-smtp.messagingengine.com ([103.168.172.153]) by makus.postgresql.org with smtp (Exim 4.96) (envelope-from ) id 1v4I8T-0012Mr-18 for pgsql-hackers@lists.postgresql.org; Thu, 02 Oct 2025 12:10:18 +0000 Received: from phl-compute-03.internal (phl-compute-03.internal [10.202.2.43]) by mailfhigh.phl.internal (Postfix) with ESMTP id 0C5591400182; Thu, 2 Oct 2025 08:10:13 -0400 (EDT) Received: from phl-mailfrontend-02 ([10.202.2.163]) by phl-compute-03.internal (MEProxy); Thu, 02 Oct 2025 08:10:13 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=burd.me; h=cc:cc :content-transfer-encoding:content-type:content-type:date:date :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to; s=fm2; t=1759407013; x=1759493413; bh=p8FRtYCsjf4KAf0D7RUPtjmQ/aYGu4WN3m4oHSNEOOw=; b= lCMoBPeobnpXH6C0bqesOJQ+xzTNYY833xbRDhIN5HRgi9E8H0ErHKRf/EJzpJFA TfWqqSisy6O+mfJ3KkHI2sIOB+s/S3OmjoraLYSvNYJ0aOQHvvqMxIJdb7jEBUI9 j3UsjnJBxplv1VQzL8h5RmBP+bhW1qzCeVVBZtCRvStZaakpYkKVLu9/LgrqYzy6 XzsKKlQ0ZqfLwsxXSSumjqvADqYNlO2CN8g/94HCer/NXNJncZvWk/uuDPLStV+Z kRqEoxu65wm+BSIaO+z/u0zmwkW2rq+4lEnfSl73UTL/IGu1ADvxqifrSe30cvRL YZJDAyrEDDoVtdxh47mYZg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm2; t=1759407013; x= 1759493413; bh=p8FRtYCsjf4KAf0D7RUPtjmQ/aYGu4WN3m4oHSNEOOw=; b=M kpGU1cL7f1q1Ff9cilS0cnZTENh9KSWsYag1JgdvuSyxf97wUygFaWkyesBSyFJA d8yGURwqjZiKT5Fbvly9ATbzVeuiQDMCM1txJUifMYXciPwtTzS9VTpzR0ktQyfQ hDMb1xitI8rnLrV6cNkPMjMtvdqQcKop6fa3tncJIj3R7IdXD31gCuhqNjOxnZkk 915osofbCE3qp8M48K1RBjshV153zjctFjdk6J3AZsHi36/u/dmurOqAhJM5tsi3 dj6cJadZxa8qfO4oYpO6yfZ28MR+1RP9JKL6vocA2gzksKk1HbjIH8z1P9r0WhQt cM9g1YfwFERVB7mUZuVug== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeeffedrtdeggdekheelkecutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpuffrtefokffrpgfnqfghnecuuegr ihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenucfjug hrpeffhffvvefkjghfuffogggtgfgusehtjehmtdertdejnecuhfhrohhmpefirhgvghcu uehurhguuceoghhrvghgsegsuhhrugdrmhgvqeenucggtffrrghtthgvrhhnpeegvdfftd elvdekteeljedvleduueevudfggeetudfgudejtdeikedtvefglefgieenucevlhhushht vghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehgrhgvghessghurhgurd hmvgdpnhgspghrtghpthhtohepgedpmhhouggvpehsmhhtphhouhhtpdhrtghpthhtohep uggrnhhivghlseihvghsqhhlrdhsvgdprhgtphhtthhopehmihgthhgrvghlsehprghquh hivghrrdighiiipdhrtghpthhtohepughgrhhofihlvgihmhhlsehgmhgrihhlrdgtohhm pdhrtghpthhtohepphhgshhqlhdqhhgrtghkvghrsheslhhishhtshdrphhoshhtghhrvg hsqhhlrdhorhhg X-ME-Proxy: Feedback-ID: i675e48f3:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Thu, 2 Oct 2025 08:10:11 -0400 (EDT) Date: Thu, 2 Oct 2025 08:09:55 -0400 From: Greg Burd To: Daniel Gustafsson Cc: Michael Paquier , David Rowley , PostgreSQL Hackers Message-ID: <11CBAA55-31FD-4920-A566-D6D735C48227@greg.burd.me> In-Reply-To: <978D21E8-9D3B-40EA-A4B1-F87BABE7868C@yesql.se> References: <978D21E8-9D3B-40EA-A4B1-F87BABE7868C@yesql.se> Subject: Re: [PATCH] Add tests for Bitmapset X-Mailer: Mailspring MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Content-Disposition: inline List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk On Oct 2 2025, at 6:00 am, Daniel Gustafsson wrote: >> On 1 Oct 2025, at 07:14, Michael Paquier wrote: > >> Thanks for the typos, I've missed these. > > Doing post-commit review I didn't see any sharp edges, but found one > more of > these so will push this shortly: > > --- Substraction to empty > +-- Subtraction to empty +1, thanks. I'll be more careful in the future. > -- > Daniel Gustafsson best. -greg