public inbox for [email protected]  

help / color / mirror / Atom feed
From: Andrei Lepikhov <[email protected]>
To: torikoshia <[email protected]>
Cc: Lukas Fittl <[email protected]>
Cc: [email protected]
Cc: Atsushi Torikoshi <[email protected]>
Cc: Robert Haas <[email protected]>
Cc: [email protected]
Cc: [email protected]
Subject: Re: RFC: Logging plan of the running query
Date: Wed, 24 Jun 2026 16:35:29 +0200
Message-ID: <[email protected]> (raw)
In-Reply-To: <[email protected]>
References: <[email protected]>
	<[email protected]>
	<CA+TgmoY81r7npTS34N_5MLA_u6ghfor5HoSaar53veXUYu1OxQ@mail.gmail.com>
	<[email protected]>
	<CA+TgmoaFp8JN2=7UFhsy0L-8NJ_MJX+HVHbmq2U2++9Em9JTnw@mail.gmail.com>
	<[email protected]>
	<CA+TgmobrSqf-PS7sgLAkAET1c8Nv7DON8VhbxjSUEL36G1mfxg@mail.gmail.com>
	<[email protected]>
	<CA+TgmoYJkk9+pMZSZyBi49Tbap7LSXf0An0boVaopDdNUhdzRQ@mail.gmail.com>
	<[email protected]>
	<[email protected]>
	<[email protected]>
	<CAP53Pkw8CX0RQY474McHyc1N8p331-asEBAEGu0X+bJX-VB8jg@mail.gmail.com>
	<[email protected]>
	<CA+TgmobUqXfn9Y40Oc0PKn7yeG62v8gwAekr=HUQjcW3OPAk5Q@mail.gmail.com>
	<[email protected]>

Hi,

I began discovering how it works.
Some minor issues after skimming through the code:
1. pg_log_query_plan - This function just sends a signal. There are no
guarantees that actual action will be performed. So, the 'request' word makes
more sense for me.
2. GetCurrentQueryDesc, SetCurrentQueryDesc - need 'extern' in the .h file
3. ExplainPrintPlan, ExplainPrintTriggers - have exact duplicates in the explain.h
4. ExplainStringAssemble() has '0' input for a boolean parameter.
5. ExecSetExecProcNodeRecurse: I don't see PlanState::initPlan. Is this intentional?
6. INJECTION_POINT("log-query-interrupt", ...) - it is called inside a
signal-safe zone. In tests, the caller might do a lot of things in the attached
routine, causing hidden problems later.

-- 
regards, Andrei Lepikhov,
pgEdge






view thread (127+ messages)  latest in thread

reply
Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected]
  Subject: Re: RFC: Logging plan of the running query
  In-Reply-To: <[email protected]>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox