Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1vxOS8-00BnKs-1q for pgsql-hackers@arkaria.postgresql.org; Tue, 03 Mar 2026 12:02:17 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.96) (envelope-from ) id 1vxOS6-006r1z-2h for pgsql-hackers@arkaria.postgresql.org; Tue, 03 Mar 2026 12:02:15 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1vxOS6-006r1q-1J for pgsql-hackers@lists.postgresql.org; Tue, 03 Mar 2026 12:02:15 +0000 Received: from mail.postgrespro.ru ([93.174.132.70]) by magus.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.98.2) (envelope-from ) id 1vxOS1-00000000B0e-1tej for pgsql-hackers@lists.postgresql.org; Tue, 03 Mar 2026 12:02:14 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=postgrespro.ru; s=mx2023; t=1772539327; bh=iGnW2sh0Lyqa9MaNJhY07W7FTUQDKAjtEMs/kywh2GI=; h=Message-ID:Date:User-Agent:Subject:To:Cc:References:From: In-Reply-To:From; b=G+rjVaqYvk4yex/PJh5mpdk+3yHl08pxDKcvsIxWiEbFqRRxvqNTfycdxGnGxhUvh eTUd46wrjDse2xw0HQtDFeRofsaSUQ5vAFYHyuMM7fPTYAf0ptSHL78kzl9NAQqx/n dANk6vN4Y4pocnk4IroHfiCjAYLMknsc8yknf5x/KOfBUicp4Rbi1y9zYMgmMHzBIy GkT8iw0RLGMjILzwXfUTkXCM8ew6ZUZWguPcTNT5gUUlK0/iXob/4vLBN2t2XXHn79 O4FcB+Eo+WeckdXh/8XxHpsrn5/QlzONsPQEbcPVJoAgq28Mcf1Vb7MhWuwRWqxzHw 65ITXGJqFj9NA== Received: from [192.168.3.107] (broadband-5-228-113-160.ip.moscow.rt.ru [5.228.113.160]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (Client did not present a certificate) (Authenticated sender: y.sokolov@postgrespro.ru) by mail.postgrespro.ru (Postfix/465) with ESMTPSA id 790BC601A0; Tue, 3 Mar 2026 15:02:07 +0300 (MSK) Message-ID: <120550bf-ca50-4a07-91b1-a88f1434ee8b@postgrespro.ru> Date: Tue, 3 Mar 2026 15:02:06 +0300 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: Fix bug in multixact Oldest*MXactId initialization and access To: Sami Imseih , Heikki Linnakangas Cc: Chao Li , "pgsql-hackers@lists.postgresql.org" References: <7acc94b0-ea82-4657-b1b0-77842cb7a60c@postgrespro.ru> <93F0BD0A-0B8B-4592-9D4B-53F405A86F6A@gmail.com> <3d7a2207-0e61-4d95-bc00-e5248956a32b@postgrespro.ru> <366b6f95-613d-4ef8-82e4-bb2fd06d9c4d@iki.fi> <231cd950-73e9-4db5-a516-c5216af7b93a@iki.fi> <944d7897-3ec3-47bb-9e93-b99f2ef3124a@postgrespro.ru> Content-Language: en-US From: Yura Sokolov In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-KSMG-AntiPhishing: NotDetected, bases: 2026/03/03 11:09:00 X-KSMG-AntiSpam-Interceptor-Info: not scanned X-KSMG-AntiSpam-Status: not scanned, disabled by settings X-KSMG-AntiVirus: Kaspersky Secure Mail Gateway, version 2.1.0.7854, bases: 2026/03/03 09:00:00 #28243224 X-KSMG-AntiVirus-Status: NotDetected, skipped X-KSMG-LinksScanning: not scanned, disabled by settings X-KSMG-Message-Action: skipped X-KSMG-Rule-ID: 1 List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk 02.03.2026 22:09, Sami Imseih пишет: >>> It says “Each is indexed by ProcNumber”, but it’s no longer accurate for OldestMemberMXactId prepared-xact entries, which now use index (procno - FIRST_PREPARED_XACT_PROC_NUMBER). >> >> Fixed those and some other comment work, and pushed. Thanks! >> > > Thanks! what are your thoughts about adding a test like the one > here [1] ? This allows us to test correct handling of prepared > transaction dummy procs. The asserts added will not cover > this case. > > What do you think? > > [1] [https://www.postgresql.org/message-id/CAA5RZ0twq5bNMq0r0QNoopQnAEv%2BJ3qJNCrLs7HVqTEntBhJ%3Dg%40mail.gmail.com] I support: test for bug fixed is a good thing. -- regards Yura Sokolov aka funny-falcon