From: Tom Lane <tgl@sss.pgh.pa.us>
To: Peter Eisentraut <peter_e@gmx.net>
cc: pgsql-hackers <pgsql-hackers@postgresql.org>
Subject: Re: need xmllint on borka
In-reply-to: <1399429219.5361.10.camel@vanquo.pezone.net>
References: <1398996306.13844.3.camel@vanquo.pezone.net>
 <11463.1398999091@sss.pgh.pa.us> <1399429219.5361.10.camel@vanquo.pezone.net>
Comments: In-reply-to Peter Eisentraut <peter_e@gmx.net>
 message dated "Tue, 06 May 2014 22:20:19 -0400"
Date: Tue, 06 May 2014 23:22:09 -0400
Message-ID: <12100.1399432929@sss.pgh.pa.us>
Precedence: bulk
Sender: pgsql-hackers-owner@postgresql.org

Peter Eisentraut <peter_e@gmx.net> writes:
> On Thu, 2014-05-01 at 22:51 -0400, Tom Lane wrote:
>> -1.  Doesn't this break "make man" for *any* hacker who doesn't have
>> xmllint installed?

> The intention is that we enforce that the documentation is correctly
> formatted.  Enforcing that only when the required tool is installed is
> the same as not enforcing it and annoying those who happen to have the
> tool installed.

Okay, but if that's the intent I suggest that the check needs to happen
somewhere more prominent than in nondefault build targets.  Personally,
I run "make man" about once a release cycle, if that often; and I'm not
sure I've ever built any of the other targets modified in this patch.
If you want to enforce correctness then I think you should put the xmllint
call into the "make all" path, which would render all of the targets
touched here rather redundant.

Also, in the vein of "is this a full-scale build requirement or not",
why is the pathname of xmllint just hard-coded into the makefile and
not something that's checked for by configure?

			regards, tom lane


-- 
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers