From: Tom Lane <tgl@sss.pgh.pa.us>
To: Arthur Zakirov <zaartur@gmail.com>
cc: =?UTF-8?Q?Juan_Jos=c3=a9_Santamar=c3=ada_Flecha?=
 <juanjo.santamaria@gmail.com>,
        Tomas Vondra <tomas.vondra@2ndquadrant.com>,
        Alvaro Herrera <alvherre@2ndquadrant.com>,
        PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Subject: Re: Allow to_date() and to_timestamp() to accept localized names
In-reply-to: <cfa38397-9fe6-70f2-e081-9aa85eb5942e@gmail.com>
References: 
 <CAC+AXB2JOe4Dw1teZP-N-isNyDdY3F96oGFVYFxhmWtsbgi=ig@mail.gmail.com>
 <20190925195745.GA21894@alvherre.pgsql>
 <CAC+AXB12A7Fr9djoq7f1-WYesnZTRKpGpHM12MRG+M00mewN9g@mail.gmail.com>
 <20200111160602.4wwvyl7lo3oxoewf@development>
 <CAC+AXB1rLC7Gu7-fTQPNwSY9sFC9hkpn8_J3WyGwaKXvNZnoVQ@mail.gmail.com>
 <ba6fa1fd-ad60-d1ea-7226-676790c108ca@gmail.com>
 <CAC+AXB2a6ei0mPFG7h-NaiBVO5=tKT67rONZmrDzoOcAE-B2Sg@mail.gmail.com>
 <31691.1579648824@sss.pgh.pa.us> <29432.1579731087@sss.pgh.pa.us>
 <cfa38397-9fe6-70f2-e081-9aa85eb5942e@gmail.com>
Comments: In-reply-to Arthur Zakirov <zaartur@gmail.com>
	message dated "Thu, 23 Jan 2020 12:17:22 +0900"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <12101.1579754521.1@sss.pgh.pa.us>
Date: Wed, 22 Jan 2020 23:42:01 -0500
Message-ID: <12102.1579754521@sss.pgh.pa.us>
Precedence: bulk

Arthur Zakirov <zaartur@gmail.com> writes:
> On 2020/01/23 7:11, Tom Lane wrote:
>> Closer examination shows that the "max" argument is pretty bogus as
>> well.  It doesn't do anything except confuse the reader, because there
>> are no cases where the value passed is less than the maximum array entry
>> length, so it never acts to change seq_search's behavior.  So we should
>> just drop that behavior from seq_search, too, and redefine "max" as
>> having no purpose except to specify how much of the string to show in
>> error messages.  There's still a question of what that should be for
>> non-English cases, but at least we now have a clear idea of what we
>> need the value to do.

> Shouldn't we just show all remaining string instead of truncating it? 

That would avoid a bunch of arbitrary decisions, for sure.
Anybody have an objection?

			regards, tom lane