Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oDq7v-0007Kb-9h for pgsql-hackers@arkaria.postgresql.org; Tue, 19 Jul 2022 16:31:15 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1oDq7u-0008Hj-58 for pgsql-hackers@arkaria.postgresql.org; Tue, 19 Jul 2022 16:31:14 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oDq7t-00085Y-Rn for pgsql-hackers@lists.postgresql.org; Tue, 19 Jul 2022 16:31:13 +0000 Received: from sss.pgh.pa.us ([66.207.139.130]) by makus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oDq7r-0004mE-KU for pgsql-hackers@lists.postgresql.org; Tue, 19 Jul 2022 16:31:12 +0000 Received: from sss1.sss.pgh.pa.us (localhost [127.0.0.1]) by sss.pgh.pa.us (8.15.2/8.15.2) with ESMTP id 26JGV8NL1210833; Tue, 19 Jul 2022 12:31:08 -0400 From: Tom Lane To: =?utf-8?Q?Dagfinn_Ilmari_Manns=C3=A5ker?= cc: pgsql-hackers@lists.postgresql.org Subject: Re: Convert planner's AggInfo and AggTransInfo to Nodes In-reply-to: <87pmi2iag8.fsf@wibble.ilmari.org> References: <742479.1658160504@sss.pgh.pa.us> <87pmi2iag8.fsf@wibble.ilmari.org> Comments: In-reply-to =?utf-8?Q?Dagfinn_Ilmari_Manns=C3=A5ker?= message dated "Mon, 18 Jul 2022 18:42:47 +0100" MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <1210831.1658248268.1@sss.pgh.pa.us> Date: Tue, 19 Jul 2022 12:31:08 -0400 Message-ID: <1210832.1658248268@sss.pgh.pa.us> List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk =?utf-8?Q?Dagfinn_Ilmari_Manns=C3=A5ker?= writes: > It seems like a reasonable idea, but I don't know enough to judge the > wider ramifications of it. But one thing that the patch should also do, > is switch to using the l*_node() functions instead of manual casting. Hm, I didn't bother with that on the grounds that there's no question what should be in those two lists. But I guess it's not much extra code, so pushed that way. regards, tom lane