Received: from malur.postgresql.org ([217.196.149.56])
	by arkaria.postgresql.org with esmtps
 (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256)
	(Exim 4.92)
	(envelope-from <pgsql-hackers-owner+archive@lists.postgresql.org>)
	id 1oDqGE-0007qC-Cf
	for pgsql-hackers@arkaria.postgresql.org; Tue, 19 Jul 2022 16:39:50 +0000
Received: from localhost ([127.0.0.1] helo=malur.postgresql.org)
	by malur.postgresql.org with esmtp (Exim 4.92)
	(envelope-from <pgsql-hackers-owner+archive@lists.postgresql.org>)
	id 1oDqGD-0001pv-9u
	for pgsql-hackers@arkaria.postgresql.org; Tue, 19 Jul 2022 16:39:49 +0000
Received: from makus.postgresql.org ([2001:4800:3e1:1::229])
	by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256)
	(Exim 4.92)
	(envelope-from <tgl@sss.pgh.pa.us>)
	id 1oDqGD-0001kd-0l
	for pgsql-hackers@lists.postgresql.org; Tue, 19 Jul 2022 16:39:49 +0000
Received: from sss.pgh.pa.us ([66.207.139.130])
	by makus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256)
	(Exim 4.92)
	(envelope-from <tgl@sss.pgh.pa.us>)
	id 1oDqGA-0004qC-Sh
	for pgsql-hackers@postgresql.org; Tue, 19 Jul 2022 16:39:47 +0000
Received: from sss1.sss.pgh.pa.us (localhost [127.0.0.1])
	by sss.pgh.pa.us (8.15.2/8.15.2) with ESMTP id 26JGdhmI1212793;
	Tue, 19 Jul 2022 12:39:43 -0400
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Jacob Champion <jchampion@timescale.com>
cc: Andres Freund <andres@anarazel.de>,
        Peter Eisentraut <peter.eisentraut@enterprisedb.com>,
        "pgsql-hackers@postgresql.org" <pgsql-hackers@postgresql.org>
Subject: Re: [PATCH] Log details for client certificate failures
In-reply-to: <c0eca922-59db-ad5c-193f-09bc36b92468@timescale.com>
References: <059e67f5-3769-24c8-f460-4e5d87af529a@enterprisedb.com>
 <0167a8c5-1754-9121-b994-0719a6493a21@timescale.com>
 <20220715191156.jecddreykoakdljm@awork3.anarazel.de>
 <ca6eb74e-aafc-f7cc-50fd-a6b33bca858b@timescale.com>
 <20220715203500.vanqxt23bmufjais@awork3.anarazel.de>
 <2878aee8-a4a6-8078-9740-efe90fcf8328@timescale.com>
 <20220715211914.c5oasfknx2njndov@awork3.anarazel.de>
 <1d3d62a0-2d7f-4592-bf76-ba59a77e61cc@timescale.com>
 <20220715234519.7o4mlpxapmqmv6p7@awork3.anarazel.de>
 <CAAWbhmiH2dPpRUnpS6pe9Fge--gj_az4ra2AJO1JvTKeiFuAug@mail.gmail.com>
 <20220719161432.qha3s76vyc6k4v5m@awork3.anarazel.de>
 <c0eca922-59db-ad5c-193f-09bc36b92468@timescale.com>
Comments: In-reply-to Jacob Champion <jchampion@timescale.com>
	message dated "Tue, 19 Jul 2022 09:30:18 -0700"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <1212791.1658248783.1@sss.pgh.pa.us>
Date: Tue, 19 Jul 2022 12:39:43 -0400
Message-ID: <1212792.1658248783@sss.pgh.pa.us>
List-Id: <pgsql-hackers.lists.postgresql.org>
List-Help: <https://lists.postgresql.org/manage/>
List-Subscribe: <https://lists.postgresql.org/manage/>
List-Post: <mailto:pgsql-hackers@lists.postgresql.org>
List-Owner: <mailto:pgsql-hackers-owner@lists.postgresql.org>
List-Archive: <https://www.postgresql.org/list/pgsql-hackers>
Archived-At: 
 <https://www.postgresql.org/message-id/1212792.1658248783%40sss.pgh.pa.us>
Precedence: bulk

Jacob Champion <jchampion@timescale.com> writes:
> On 7/19/22 09:14, Andres Freund wrote:
>> IMO this should replace the existing ascii escape function instead.

> That will affect the existing behavior of application_name and
> cluster_name; is that acceptable?

I think Andres' point is exactly that these should all act alike.

Having said that, I struggle to see why we are panicking about badly
encoded log data from this source while blithely ignoring the problems
posed by non-ASCII role names, database names, and tablespace names.

			regards, tom lane