Message-ID: <1215f2de-3c49-eb3a-e62b-da1c05cb51db@dunslane.net>
Date: Thu, 2 Feb 2023 09:06:36 -0500
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.5.0
Subject: Re: run pgindent on a regular basis / scripted manner
Content-Language: en-US
To: Tom Lane <tgl@sss.pgh.pa.us>, Noah Misch <noah@leadboat.com>
Cc: Bruce Momjian <bruce@momjian.us>, Jelte Fennema <postgres@jeltef.nl>,
 Andres Freund <andres@anarazel.de>, Peter Geoghegan <pg@bowt.ie>,
 Magnus Hagander <magnus@hagander.net>,
 Alvaro Herrera <alvherre@2ndquadrant.com>, Stephen Frost
 <sfrost@snowman.net>, Jesse Zhang <sbjesse@gmail.com>,
 PostgreSQL-development <pgsql-hackers@postgresql.org>
References: <20230123011002.fzcaa3krql3mqsfn@awork3.anarazel.de>
 <1509591.1674437376@sss.pgh.pa.us> <1608158.1674486546@sss.pgh.pa.us>
 <20230123173136.knn77pbuakhvjfgk@awork3.anarazel.de>
 <Y874Fh0q4mkk1s22@momjian.us>
 <CAGECzQTqoGHrePM_pwmhaM+J1XOygYjzFod4sf=PAt7J4A19Mw@mail.gmail.com>
 <2238493.1674572097@sss.pgh.pa.us> <Y9ArogF7c+UgPgq9@momjian.us>
 <20230129010603.GA1677550@rfd.leadboat.com> <Y9groc0Nyy7SOROy@momjian.us>
 <20230202062838.GA1832088@rfd.leadboat.com>
 <1477791.1675320029@sss.pgh.pa.us>
From: Andrew Dunstan <andrew@dunslane.net>
In-Reply-To: <1477791.1675320029@sss.pgh.pa.us>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Archived-At: 
 <https://www.postgresql.org/message-id/1215f2de-3c49-eb3a-e62b-da1c05cb51db%40dunslane.net>
Precedence: bulk


On 2023-02-02 Th 01:40, Tom Lane wrote:
> Noah Misch <noah@leadboat.com> writes:
>> Regarding the concern about a pre-receive hook blocking an emergency push, the
>> hook could approve every push where a string like "pgindent: no" appears in a
>> commit message within the push.  You'd still want to make the tree clean
>> sometime the same week or so.  It's cheap to provide a break-glass like that.
> I think the real question here is whether we can get all (or at least
> a solid majority of) committers to accept such draconian constraints.
> I'd buy into it, and evidently so would you, but I can't help noting
> that less than a quarter of active committers have bothered to
> comment on this thread.  I suspect the other three-quarters would
> be quite annoyed if we tried to institute such requirements.  That's
> not manpower we can afford to drive away.


I'd be very surprised if this caused any active committer to walk away
from the project. Many will probably appreciate the nudge. But maybe I'm
overoptimistic.


>
> Maybe this should get taken up at the this-time-for-sure developer
> meeting at PGCon?
>
> 			


Sure. There's probably some work that could still be done in this area
too, such as making pgperltidy work similarly to how we've now make
pgindent work.


There's also a question of timing. Possibly the best time would be when
we next fork the tree.


cheers


andrew

--
Andrew Dunstan
EDB: https://www.enterprisedb.com