Received: from malur.postgresql.org ([217.196.149.56])
	by arkaria.postgresql.org with esmtps
 (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256)
	(Exim 4.92)
	(envelope-from <pgsql-hackers-owner+archive@lists.postgresql.org>)
	id 1pJd3E-0002yf-IB
	for pgsql-hackers@arkaria.postgresql.org; Sun, 22 Jan 2023 16:18:36 +0000
Received: from localhost ([127.0.0.1] helo=malur.postgresql.org)
	by malur.postgresql.org with esmtp (Exim 4.92)
	(envelope-from <pgsql-hackers-owner+archive@lists.postgresql.org>)
	id 1pJd3C-0000N5-HT
	for pgsql-hackers@arkaria.postgresql.org; Sun, 22 Jan 2023 16:18:34 +0000
Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29])
	by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256)
	(Exim 4.92)
	(envelope-from <tgl@sss.pgh.pa.us>)
	id 1pJd3C-0000Mv-7o
	for pgsql-hackers@lists.postgresql.org; Sun, 22 Jan 2023 16:18:34 +0000
Received: from sss.pgh.pa.us ([66.207.139.130])
	by magus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256)
	(Exim 4.92)
	(envelope-from <tgl@sss.pgh.pa.us>)
	id 1pJd3A-0006eO-CA
	for pgsql-hackers@lists.postgresql.org; Sun, 22 Jan 2023 16:18:33 +0000
Received: from sss1.sss.pgh.pa.us (localhost [127.0.0.1])
	by sss.pgh.pa.us (8.15.2/8.15.2) with ESMTP id 30MGITTS1217036;
	Sun, 22 Jan 2023 11:18:29 -0500
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Andrew Dunstan <andrew@dunslane.net>
cc: pgsql-hackers@lists.postgresql.org
Subject: Re: run pgindent on a regular basis / scripted manner
In-reply-to: <55588553-a433-96ec-fdfe-fd46ac6f3a4a@dunslane.net>
References: 
 <CABUevExkB=+FX5Ht2sU6Tmk1fF0h8LqugW5camQ-r00ftPZoSg@mail.gmail.com>
 <20200814202651.GA31108@alvherre.pgsql>
 <CABUevEwGPPaUtObrDywO+vhpFDTJXO+-aeWJd7D46uXTE2sQpA@mail.gmail.com>
 <CAGECzQQs+hz4uQSmD_8oRLr74GtxpE0iXuYE85+RHAzvkF_yvQ@mail.gmail.com>
 <531251.1674234545@sss.pgh.pa.us>
 <20230120175806.iogdcra2xpmmh5de@awork3.anarazel.de>
 <538672.1674238787@sss.pgh.pa.us>
 <c9c9fa6d-6de6-48c2-4f8b-0fbeef026439@dunslane.net>
 <17455b0f-0161-9aa9-b6dd-1279e947b8f4@dunslane.net>
 <3cdb09f1-6375-4198-e8c1-e33ca4c96304@dunslane.net>
 <a55329d4-84b5-6615-2c66-98856c6b94a7@dunslane.net>
 <912484.1674317408@sss.pgh.pa.us>
 <55588553-a433-96ec-fdfe-fd46ac6f3a4a@dunslane.net>
Comments: In-reply-to Andrew Dunstan <andrew@dunslane.net>
	message dated "Sun, 22 Jan 2023 10:01:13 -0500"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <1217034.1674404309.1@sss.pgh.pa.us>
Date: Sun, 22 Jan 2023 11:18:29 -0500
Message-ID: <1217035.1674404309@sss.pgh.pa.us>
List-Id: <pgsql-hackers.lists.postgresql.org>
List-Help: <https://lists.postgresql.org/manage/>
List-Subscribe: <https://lists.postgresql.org/manage/>
List-Post: <mailto:pgsql-hackers@lists.postgresql.org>
List-Owner: <mailto:pgsql-hackers-owner@lists.postgresql.org>
List-Archive: <https://www.postgresql.org/list/pgsql-hackers>
Archived-At: 
 <https://www.postgresql.org/message-id/1217035.1674404309%40sss.pgh.pa.us>
Precedence: bulk

Andrew Dunstan <andrew@dunslane.net> writes:
>> ... btw, can we get away with making the diff run be "diff -upd"
>> not just "diff -u"?  I find diff output for C files noticeably
>> more useful with those options, but I'm unsure about their
>> portability.

> I think they are available on Linux, MacOS and FBSD, and on Windows (if
> anyone's actually using it for this) it's likely to be Gnu diff. So I
> think that's probably enough coverage.

I checked NetBSD as well, and it has all three too.

Patch looks good to me.

			regards, tom lane