Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1o6lPw-00072k-Gj for pgsql-hackers@arkaria.postgresql.org; Thu, 30 Jun 2022 04:04:36 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1o6lPu-0000fx-Ei for pgsql-hackers@arkaria.postgresql.org; Thu, 30 Jun 2022 04:04:34 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1o6lPu-0000fo-5r for pgsql-hackers@lists.postgresql.org; Thu, 30 Jun 2022 04:04:34 +0000 Received: from mail.nataraj.su ([88.198.198.57]) by magus.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1o6lPn-0005Sv-BY for pgsql-hackers@lists.postgresql.org; Thu, 30 Jun 2022 04:04:33 +0000 Received: from thinkpad-pgpro.localnet (unknown [91.203.188.92]) by mail.nataraj.su (Postfix) with ESMTPSA id D53589D5A3; Thu, 30 Jun 2022 04:04:25 +0000 (UTC) From: Nikolay Shaplov To: pgsql-hackers@lists.postgresql.org, Jacob Champion Subject: Re: [PATCH] minor reloption regression tests improvement Date: Thu, 30 Jun 2022 07:04:25 +0300 Message-ID: <12182567.IpiZAh8j0P@thinkpad-pgpro> Organization: Postgres Professional In-Reply-To: <2590342.64y9vfTr7p@thinkpad-pgpro> References: <4563991.km65PDbjlG@thinkpad-pgpro> <165653872847.1152.5920509051824255715.pgcf@coridan.postgresql.org> <2590342.64y9vfTr7p@thinkpad-pgpro> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="nextPart3115804.f4voHmy23L"; micalg="pgp-sha512"; protocol="application/pgp-signature" List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk --nextPart3115804.f4voHmy23L Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="UTF-8"; protected-headers="v1" From: Nikolay Shaplov To: pgsql-hackers@lists.postgresql.org, Jacob Champion Subject: Re: [PATCH] minor reloption regression tests improvement Date: Thu, 30 Jun 2022 07:04:25 +0300 Message-ID: <12182567.IpiZAh8j0P@thinkpad-pgpro> Organization: Postgres Professional In-Reply-To: <2590342.64y9vfTr7p@thinkpad-pgpro> References: <4563991.km65PDbjlG@thinkpad-pgpro> <165653872847.1152.5920509051824255715.pgcf@coridan.postgresql.org> <2590342.64y9vfTr7p@thinkpad-pgpro> =D0=92 =D0=BF=D0=B8=D1=81=D1=8C=D0=BC=D0=B5 =D0=BE=D1=82 =D1=87=D0=B5=D1=82= =D0=B2=D0=B5=D1=80=D0=B3, 30 =D0=B8=D1=8E=D0=BD=D1=8F 2022 =D0=B3. 06:47:48= MSK =D0=BF=D0=BE=D0=BB=D1=8C=D0=B7=D0=BE=D0=B2=D0=B0=D1=82=D0=B5=D0=BB=D1= =8C Nikolay Shaplov=20 =D0=BD=D0=B0=D0=BF=D0=B8=D1=81=D0=B0=D0=BB: =20 > Hi! I am surely feel this patch is important. I have bigger patch > https://commitfest.postgresql.org/38/3536/ and this test makes sense as a > part of big work of options refactoring, >=20 > I am also was strongly advised to commit things chopped into smaller part= s, > when possible. This test can be commit separately so I am doing it. Let me again explain why this test is importaint, so potential reviewers ca= n=20 easily find this information. Tests are for developers. You change the code and see that something does n= ot=20 work anymore, as it worked before. When you change the code, you should keep both documented and undocumented= =20 behaviour. Because user's code can intentionally or accidentally use it.=20 So known undocumented behavior is better to be tested as well as documented= =20 one. If you as developer want to change undocumented behavior, it is better= to=20 do it consciously. This test insures that. I, personally hit this problem while working with reloption code. Older=20 version of my new patch changed this behaviour, and I even did not notice=20 that. So I decided to write this test to ensure, that nobody ever meet same= =20 problem.=20 And as I said before, I was strongly advised to commit in small parts, when= =20 possible. This test can be commit separately. =20 =2D-=20 Nikolay Shaplov aka Nataraj =46uzzing Engineer at Postgres Professional Matrix IM: @dhyan:nataraj.su --nextPart3115804.f4voHmy23L Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part. Content-Transfer-Encoding: 7Bit -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEE+sk3ebqQKlezKOi8PMbfuIHAGpgFAmK9IMkACgkQPMbfuIHA GphV8Qf7BHQkQA3D3xCTUeRyBZo9DE+FSOfPmCqc0za+WqnTfFCbrxYg2UX/Vrf3 s82kJJQscYG8bIoLZ9QECRc/tsS0AXjJEr2rUB4LIDADguNnrhNoBvtNlqHT8q/w /c+aCGqXfNtJ4PWu1UkVGwQoe9Ri4NzpB4iBSFgy+x+GcxP12PSKUJzzNQ0FmyUa ypaBDqfxnb+upNp6JOy9yrbUpFZ1EBrhwzc//IKaKIuH4+iAJKYEx5p5T1uBzmWK V2Sz+LvbFeHqBv+sDiQKBNvIE6nO05kZbnU6hzO9JOthDBDdhaeI1aI3DhfHUuwU CH6EphWNE82zg4i/LrB18KHsJMo75w== =outf -----END PGP SIGNATURE----- --nextPart3115804.f4voHmy23L--