Received: from malur.postgresql.org ([217.196.149.56])
	by arkaria.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256)
	(Exim 4.89)
	(envelope-from <pgsql-hackers-owner+archive@lists.postgresql.org>)
	id 1hbR9w-0004O9-9T
	for pgsql-hackers@arkaria.postgresql.org; Thu, 13 Jun 2019 14:57:00 +0000
Received: from localhost ([127.0.0.1] helo=malur.postgresql.org)
	by malur.postgresql.org with esmtp (Exim 4.89)
	(envelope-from <pgsql-hackers-owner+archive@lists.postgresql.org>)
	id 1hbR9v-00088Z-4V
	for pgsql-hackers@arkaria.postgresql.org; Thu, 13 Jun 2019 14:56:59 +0000
Received: from makus.postgresql.org ([2001:4800:3e1:1::229])
	by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256)
	(Exim 4.89)
	(envelope-from <tgl@sss.pgh.pa.us>)
	id 1hbR9u-00088R-PH
	for pgsql-hackers@lists.postgresql.org; Thu, 13 Jun 2019 14:56:58 +0000
Received: from sss.pgh.pa.us ([66.207.139.130])
	by makus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256)
	(Exim 4.89)
	(envelope-from <tgl@sss.pgh.pa.us>)
	id 1hbR9s-0002ew-GQ
	for pgsql-hackers@postgresql.org; Thu, 13 Jun 2019 14:56:57 +0000
Received: from sss1.sss.pgh.pa.us (localhost [127.0.0.1])
	by sss.pgh.pa.us (8.14.4/8.14.4) with ESMTP id x5DEugb9012203;
	Thu, 13 Jun 2019 10:56:43 -0400
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Pavlo Golub <pavlo.golub@cybertec.at>
cc: PostgreSQL-development <pgsql-hackers@postgresql.org>,
        Craig Ringer <craig@2ndquadrant.com>
Subject: Re: ReplicationSlotCtl: undefined reference
In-reply-to: <345138875.20190611151943@cybertec.at>
References: <345138875.20190611151943@cybertec.at>
Comments: In-reply-to Pavlo Golub <pavlo.golub@cybertec.at>
	message dated "Tue, 11 Jun 2019 15:19:43 +0300"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <12201.1560437802.1@sss.pgh.pa.us>
Content-Transfer-Encoding: quoted-printable
Date: Thu, 13 Jun 2019 10:56:42 -0400
Message-ID: <12202.1560437802@sss.pgh.pa.us>
List-Id: <pgsql-hackers.lists.postgresql.org>
List-Help: <https://lists.postgresql.org/manage/>
List-Subscribe: <https://lists.postgresql.org/manage/>
List-Post: <mailto:pgsql-hackers@lists.postgresql.org>
List-Owner: <mailto:pgsql-hackers-owner@lists.postgresql.org>
List-Archive: <https://www.postgresql.org/list/pgsql-hackers>
Precedence: bulk

Pavlo Golub <pavlo.golub@cybertec.at> writes:
> Trying to build pg extension I've got error:
> ```
> pglogical_monitoring.o:pglogical_monitoring.c:(.rdata$.refptr.Replicatio=
nSlotCtl[.refptr.ReplicationSlotCtl]+0x0): undefined reference to `Replica=
tionSlotCtl'
> collect2: error: ld returned 1 exit status
> ```

> But according to https://commitfest.postgresql.org/16/1390/ it should
> be marked with PGDLLIMPORT.

That last bit never actually got pushed, it seems.  Done now.

			regards, tom lane