Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1s1RJw-00CKWk-Ew for pgsql-hackers@arkaria.postgresql.org; Mon, 29 Apr 2024 13:45:28 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.94.2) (envelope-from ) id 1s1RJt-00HFvs-VT for pgsql-hackers@arkaria.postgresql.org; Mon, 29 Apr 2024 13:45:26 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1s1RJt-00HFvk-MC for pgsql-hackers@lists.postgresql.org; Mon, 29 Apr 2024 13:45:26 +0000 Received: from sss.pgh.pa.us ([68.162.161.243]) by magus.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1s1RJq-000gLk-7w for pgsql-hackers@postgresql.org; Mon, 29 Apr 2024 13:45:25 +0000 Received: from sss1.sss.pgh.pa.us (localhost [127.0.0.1]) by sss.pgh.pa.us (8.15.2/8.15.2) with ESMTP id 43TDjGv21222344; Mon, 29 Apr 2024 09:45:16 -0400 From: Tom Lane To: Richard Guo cc: Michael Paquier , PostgreSQL-development Subject: Re: A failure in prepared_xacts test In-reply-to: References: <1068977.1714367460@sss.pgh.pa.us> <1076837.1714368760@sss.pgh.pa.us> Comments: In-reply-to Richard Guo message dated "Mon, 29 Apr 2024 17:11:19 +0800" MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <1222342.1714398316.1@sss.pgh.pa.us> Date: Mon, 29 Apr 2024 09:45:16 -0400 Message-ID: <1222343.1714398316@sss.pgh.pa.us> List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk Richard Guo writes: > I noticed that some TAP tests from recovery and subscription would > select the count from pg_prepared_xacts. I wonder if these tests would > be affected if there are any prepared transactions on the backend. TAP tests shouldn't be at risk, because there is no "make installcheck" equivalent for them. Each TAP test creates its own database instance (or maybe several), so that instance won't have anything else going on. regards, tom lane