Received: from localhost (unknown [200.46.204.183]) by postgresql.org (Postfix) with ESMTP id 3FA2C64FDE3 for ; Thu, 30 Oct 2008 06:58:36 -0300 (ADT) Received: from postgresql.org ([200.46.204.86]) by localhost (mx1.hub.org [200.46.204.183]) (amavisd-maia, port 10024) with ESMTP id 59522-02 for ; Thu, 30 Oct 2008 06:58:32 -0300 (ADT) X-Greylist: from auto-whitelisted by SQLgrey-1.7.6 Received: from outmail137185.authsmtp.com (outmail137185.authsmtp.com [62.13.137.185]) by postgresql.org (Postfix) with ESMTP id 9EE6E64FCEC for ; Thu, 30 Oct 2008 06:58:32 -0300 (ADT) Received: from mail-c189.authsmtp.com (mail-c189.authsmtp.com [62.13.128.71]) by punt5.authsmtp.com (8.14.2/8.14.2/Kp) with ESMTP id m9U9vuh7085199; Thu, 30 Oct 2008 09:57:56 GMT Received: from [192.168.0.3] (85-211-99-122.dyn.gotadsl.co.uk [85.211.99.122]) (authenticated bits=0) by mail.authsmtp.com (8.14.2/8.14.2/Kp) with ESMTP id m9U9vtfg011393; Thu, 30 Oct 2008 09:57:55 GMT Subject: Re: Updating FSM on recovery From: Simon Riggs To: Heikki Linnakangas Cc: Tom Lane , PostgreSQL-development In-Reply-To: <490972E5.1010605@enterprisedb.com> References: <49072021.7010801@enterprisedb.com> <24334.1225205478@sss.pgh.pa.us> <49074779.2080309@enterprisedb.com> <9672.1225215390@sss.pgh.pa.us> <49085327.5010608@enterprisedb.com> <11303.1225283814@sss.pgh.pa.us> <490972E5.1010605@enterprisedb.com> Content-Type: text/plain Date: Thu, 30 Oct 2008 09:57:58 +0000 Message-Id: <1225360678.3971.362.camel@ebony.2ndQuadrant> Mime-Version: 1.0 X-Mailer: Evolution 2.12.0 Content-Transfer-Encoding: 7bit X-Server-Quench: 39774770-a669-11dd-bc7a-001f29070be2 X-AuthRoute: OCdxZQATClZOTQEd DAteCiNZVAwpPBRK HVkIKg5MJUcNSQVJ NksadRtFawVbYlpF HGQLW1xEUFR7XGR/ bg8fZQBDYEtPQQxj TklLQE1QEQdtHhxP Wxd7W182IVJGeX9z bEUsX3NSXAp5fEF6 RklTFXBXY2FpdWEe BBRFJVBTIR5Kfh4T aFl/U3NfNGdJBC9q VzwTFhsSEA9kHWxo Wg0EMVMUTg4lJRt0 QBZKBzgkGlMIXTRb X-Authentic-SMTP: 61633235383639.kestrel.dmpriest.net.uk:1378/Kp X-Report-SPAM: If SPAM / abuse - report it at: http://www.authsmtp.com/abuse X-Virus-Status: No virus detected - but ensure you scan with your own anti-virus system! X-Virus-Scanned: Maia Mailguard 1.0.1 X-Spam-Status: No, hits=0 tagged_above=0 required=5 tests=none X-Spam-Level: X-Archive-Number: 200810/1562 X-Sequence-Number: 126579 On Thu, 2008-10-30 at 10:40 +0200, Heikki Linnakangas wrote: > So, attached is a patch using an enum. Barring objections, I'll commit > this. I probably agree with the changes from reading your post, but I'd ask that you hang fire on committing this for a few days. It's just going to prevent Koichi and myself from submitting clean patches on F-Day, or it will cause us to spend time on rework before we've even submitted the patch. I'd like to avoid the pileup for now, though don't have any problem with the rework after that point. Thanks, -- Simon Riggs www.2ndQuadrant.com PostgreSQL Training, Services and Support