Received: from localhost (unknown [200.46.204.183]) by postgresql.org (Postfix) with ESMTP id 8A11764FFA2 for ; Thu, 30 Oct 2008 07:05:38 -0300 (ADT) Received: from postgresql.org ([200.46.204.86]) by localhost (mx1.hub.org [200.46.204.183]) (amavisd-maia, port 10024) with ESMTP id 63011-01 for ; Thu, 30 Oct 2008 07:05:33 -0300 (ADT) X-Greylist: from auto-whitelisted by SQLgrey-1.7.6 Received: from outmail137194.authsmtp.com (outmail137194.authsmtp.com [62.13.137.194]) by postgresql.org (Postfix) with ESMTP id A011164FDE3 for ; Thu, 30 Oct 2008 07:05:30 -0300 (ADT) Received: from mail-c189.authsmtp.com (mail-c189.authsmtp.com [62.13.128.71]) by punt6.authsmtp.com (8.14.2/8.14.2/Kp) with ESMTP id m9UA4tW7066937; Thu, 30 Oct 2008 10:04:55 GMT Received: from [192.168.0.3] (85-211-99-122.dyn.gotadsl.co.uk [85.211.99.122]) (authenticated bits=0) by mail.authsmtp.com (8.14.2/8.14.2/Kp) with ESMTP id m9UA4sDr013014; Thu, 30 Oct 2008 10:04:54 GMT Subject: Re: Updating FSM on recovery From: Simon Riggs To: Heikki Linnakangas Cc: Tom Lane , PostgreSQL-development In-Reply-To: <1225360678.3971.362.camel@ebony.2ndQuadrant> References: <49072021.7010801@enterprisedb.com> <24334.1225205478@sss.pgh.pa.us> <49074779.2080309@enterprisedb.com> <9672.1225215390@sss.pgh.pa.us> <49085327.5010608@enterprisedb.com> <11303.1225283814@sss.pgh.pa.us> <490972E5.1010605@enterprisedb.com> <1225360678.3971.362.camel@ebony.2ndQuadrant> Content-Type: text/plain Date: Thu, 30 Oct 2008 10:04:57 +0000 Message-Id: <1225361097.3971.367.camel@ebony.2ndQuadrant> Mime-Version: 1.0 X-Mailer: Evolution 2.12.0 Content-Transfer-Encoding: 7bit X-Server-Quench: 332ab6c4-a66a-11dd-bc7a-001f29070be2 X-AuthRoute: OCdxZQATClZOTQEd DAteCiNZVAwpPBRK HVkIKg5MJUcNSQVJ NksadRtFawVbYlpF HGQLW1xEUV17WWd/ bg4fZQBDYEtPQQxj TklLQE1QEQdtHhxP Wxd7Ix0xA0dGeX1w ZEIsX3RbXAp5dkQs EEgHEXBXY2ExdWEe BBRFJVBTIR5Kfh4T aFl/U3NfNGdJBC9q VzwTFhsSEA9kHWxo Wg0EMVMUTg4lJRt0 QBZKBzgkGlMIXTRb X-Authentic-SMTP: 61633235383639.kestrel.dmpriest.net.uk:1378/Kp X-Report-SPAM: If SPAM / abuse - report it at: http://www.authsmtp.com/abuse X-Virus-Status: No virus detected - but ensure you scan with your own anti-virus system! X-Virus-Scanned: Maia Mailguard 1.0.1 X-Spam-Status: No, hits=0 tagged_above=0 required=5 tests=none X-Spam-Level: X-Archive-Number: 200810/1563 X-Sequence-Number: 126580 On Thu, 2008-10-30 at 09:57 +0000, Simon Riggs wrote: > On Thu, 2008-10-30 at 10:40 +0200, Heikki Linnakangas wrote: > > > So, attached is a patch using an enum. Barring objections, I'll commit > > this. > > I probably agree with the changes from reading your post, but I'd ask > that you hang fire on committing this for a few days. Best thing from here is for me to just freeze my tree for next few days. It will make my submission a few days out of date, but we can fix that up fairly quickly. -- Simon Riggs www.2ndQuadrant.com PostgreSQL Training, Services and Support