Received: from malur.postgresql.org ([217.196.149.56])
	by arkaria.postgresql.org with esmtps  (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384
	(Exim 4.96)
	(envelope-from <pgsql-hackers-owner+archive@lists.postgresql.org>)
	id 1vnHfC-004dAu-1T
	for pgsql-hackers@arkaria.postgresql.org;
	Tue, 03 Feb 2026 14:45:58 +0000
Received: from localhost ([127.0.0.1] helo=malur.postgresql.org)
	by malur.postgresql.org with esmtp (Exim 4.96)
	(envelope-from <pgsql-hackers-owner+archive@lists.postgresql.org>)
	id 1vnHfB-005B2g-1r
	for pgsql-hackers@arkaria.postgresql.org;
	Tue, 03 Feb 2026 14:45:57 +0000
Received: from makus.postgresql.org ([2001:4800:3e1:1::229])
	by malur.postgresql.org with esmtps  (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384
	(Exim 4.96)
	(envelope-from <tgl@sss.pgh.pa.us>)
	id 1vnHfB-005B2Y-0w
	for pgsql-hackers@lists.postgresql.org;
	Tue, 03 Feb 2026 14:45:57 +0000
Received: from sss.pgh.pa.us ([68.162.161.243])
	by makus.postgresql.org with esmtps  (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384
	(Exim 4.98.2)
	(envelope-from <tgl@sss.pgh.pa.us>)
	id 1vnHf9-00000000N56-1Ssm
	for pgsql-hackers@postgresql.org;
	Tue, 03 Feb 2026 14:45:56 +0000
Received: from sss1.sss.pgh.pa.us (localhost [127.0.0.1])
	by sss.pgh.pa.us (8.15.2/8.15.2) with ESMTP id 613EjnHv1226921;
	Tue, 3 Feb 2026 09:45:50 -0500
From: Tom Lane <tgl@sss.pgh.pa.us>
To: "=?ISO-8859-1?B?emVuZ21hbg==?=" <zengman@halodbtech.com>
cc: "=?ISO-8859-1?B?cGdzcWwtaGFja2Vycw==?=" <pgsql-hackers@postgresql.org>
Subject: Re: Remove unused isCommit parameter from AtEOXact_LocalBuffers
In-reply-to: <tencent_17B13D9206FD633428A9DA3A@qq.com>
References: <tencent_17B13D9206FD633428A9DA3A@qq.com>
Comments: In-reply-to "=?ISO-8859-1?B?emVuZ21hbg==?=" <zengman@halodbtech.com>
	message dated "Tue, 03 Feb 2026 20:08:29 +0800"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <1226919.1770129949.1@sss.pgh.pa.us>
Content-Transfer-Encoding: quoted-printable
Date: Tue, 03 Feb 2026 09:45:49 -0500
Message-ID: <1226920.1770129949@sss.pgh.pa.us>
List-Id: <pgsql-hackers.lists.postgresql.org>
List-Help: <https://lists.postgresql.org/manage/>
List-Subscribe: <https://lists.postgresql.org/manage/>
List-Post: <mailto:pgsql-hackers@lists.postgresql.org>
List-Owner: <mailto:pgsql-hackers-owner@lists.postgresql.org>
List-Archive: <https://www.postgresql.org/list/pgsql-hackers>
Archived-At: <https://www.postgresql.org/message-id/1226920.1770129949%40sss.pgh.pa.us>
Precedence: bulk

"=3D?ISO-8859-1?B?emVuZ21hbg=3D=3D?=3D" <zengman@halodbtech.com> writes:
> Commit fdd13f156814f81732c188788ab1b7b14c59f4da removed the above code, =
but the `isCommit` parameter was left intact. =

> I intend to remove this unused parameter, and also clean up the call sit=
e in `AtEOXact_Buffers` since it invokes `AtEOXact_LocalBuffers`.

I think we should reject this as useless code churn.  The parameter
was needed in the past and might be needed again in the future.
It's fairly common for other AtEOXact functions to take an isCommit
flag, so I don't find it surprising for these to have one.

			regards, tom lane