From: Tom Lane <tgl@sss.pgh.pa.us>
To: Andres Freund <andres@anarazel.de>
cc: pgsql-hackers@postgresql.org, Stephen Frost <sfrost@snowman.net>,
        "Jonathan S. Katz" <jkatz@postgresql.org>
Subject: Re: Why do we define HAVE_GSSAPI_EXT_H?
In-reply-to: <20240708225659.gmyqoosi7km6ysgn@awork3.anarazel.de>
References: <20240708225659.gmyqoosi7km6ysgn@awork3.anarazel.de>
Comments: In-reply-to Andres Freund <andres@anarazel.de>
	message dated "Mon, 08 Jul 2024 15:56:59 -0700"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <1228647.1720479932.1@sss.pgh.pa.us>
Content-Transfer-Encoding: quoted-printable
Date: Mon, 08 Jul 2024 19:05:32 -0400
Message-ID: <1228648.1720479932@sss.pgh.pa.us>
Archived-At: <https://www.postgresql.org/message-id/1228648.1720479932%40sss.pgh.pa.us>
Precedence: bulk

Andres Freund <andres@anarazel.de> writes:
> configure/meson define HAVE_GSSAPI_EXT_H / HAVE_GSSAPI_GSSAPI_EXT_H - bu=
t
> afaict we don't use those anywhere?

It looks to me like it's just a byproduct of the autoconf macros
we use to verify that you have a sane installation:

if test "$with_gssapi" =3D yes ; then
  AC_CHECK_HEADERS(gssapi/gssapi.h, [],
	[AC_CHECK_HEADERS(gssapi.h, [], [AC_MSG_ERROR([gssapi.h header file is re=
quired for GSSAPI])])])
  AC_CHECK_HEADERS(gssapi/gssapi_ext.h, [],
	[AC_CHECK_HEADERS(gssapi_ext.h, [], [AC_MSG_ERROR([gssapi_ext.h header fi=
le is required for GSSAPI])])])
fi

There might be a variant of AC_CHECK_HEADERS that doesn't have
the default define-a-symbol action, not sure.

Maybe it's not really necessary to check both gssapi.h and
gssapi_ext.h, but I'm not very familiar with all the variants of
GSSAPI that are out there.

			regards, tom lane