From: Nikolay Shaplov <dhyan@nataraj.su>
To: pgsql-hackers@lists.postgresql.org
Cc: Alvaro Herrera <alvherre@alvh.no-ip.org>,
 Nikita Glukhov <n.gluhov@postgrespro.ru>,
 PostgreSQL mailing lists <pgsql-hackers@postgresql.org>
Subject: Re: [PATCH][PROPOSAL] Add enum releation option type
Date: Wed, 07 Mar 2018 18:23:03 +0300
Message-ID: <12291633.PFnvXaAOpE@x200m>
User-Agent: KMail/4.14.1 (Linux/3.16.0-4-amd64; KDE/4.14.2; x86_64; ; )
In-Reply-To: <20180301174735.yyu6i5y66u3xp3jc@alvherre.pgsql>
References: <20180301174735.yyu6i5y66u3xp3jc@alvherre.pgsql>
MIME-Version: 1.0
Content-Type: multipart/signed; boundary="nextPart2759738.eOYBajmp0K";
 micalg="pgp-sha256"; protocol="application/pgp-signature"
Precedence: bulk


--nextPart2759738.eOYBajmp0K
Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain; charset="utf-8"

=D0=92 =D0=BF=D0=B8=D1=81=D1=8C=D0=BC=D0=B5 =D0=BE=D1=82 1 =D0=BC=D0=B0=
=D1=80=D1=82=D0=B0 2018 14:47:35 =D0=BF=D0=BE=D0=BB=D1=8C=D0=B7=D0=BE=D0=
=B2=D0=B0=D1=82=D0=B5=D0=BB=D1=8C Alvaro Herrera =D0=BD=D0=B0=D0=BF=D0=B8=
=D1=81=D0=B0=D0=BB:

> I see you lost the Oxford comma:
>=20
> -DETAIL:  Valid values are "on", "off", and "auto".
> +DETAIL:  Valid values are "auto", "on" and "off".
>=20
> Please put these back.
Actually that's me who have lost it. The code with  oxford comma would =
be a=20
bit more complicated. We should put such coma when we have 3+ items and=
 do not=20
put it when we have 2.

Does it worth it?

As I've read oxford using of comma is not mandatory and used to avoid=20=

ambiguity.
"XXX, YYY and ZZZ" can be read as "XXX, YYY, ZZZ" or as "XXX, (YYY and =
ZZZ)".
oxford comma is used to make sure that YYY and ZZZ are separate items o=
f the=20
list, not an expression inside one item.

But here we hardly have such ambiguity.

So I'll ask again, do you really think it worth it?


=2D-=20
Do code for fun.
--nextPart2759738.eOYBajmp0K
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: This is a digitally signed message part.
Content-Transfer-Encoding: 7Bit

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2

iQEcBAABCAAGBQJaoAPXAAoJEKc13HowK+H4kmoH/08IUxPTbLtgM2yNI+WZ7Fcw
B/dl314Cc+hGEp6oxO8Ol3YWQqNiSfrb0ARLs1c+SxT9rkaWVIHhKI+pQck8L/Cj
G4YURyytIOf97X9q1UpOA22qop4fRHilOSes0vps7q/lZH7Fot6Ixkzgf2xN5c8j
i+YFcXDFEp79FtA/z3RcbB9D77VoN9Lto1QHfvky12HUcfcyJ6J/yGVrrtGLlzO4
3GzCrBQG+ZELSQFHAcbSYUdX9RAaYV9YfY70FO6dMfNUz+SpM1FNDGKTGaR8ISfS
z5MKFShPBdxHavQ5ELk0M7gwth2hKvaekaZ6JwTfxE31aJfOjyTvtMLIStJ5PjY=
=fSDV
-----END PGP SIGNATURE-----

--nextPart2759738.eOYBajmp0K--