public inbox for [email protected]  

help / color / mirror / Atom feed

From: Andrew Dunstan <[email protected]>
To: Matheus Alcantara <[email protected]>
To: Peter Eisentraut <[email protected]>
Cc: PostgreSQL-development <[email protected]>
Cc: Gabriele Bartolini <[email protected]>
Cc: Craig Ringer <[email protected]>
Cc: David E. Wheeler <[email protected]>
Cc: Robert Haas <[email protected]>
Cc: Alvaro Herrera <[email protected]>
Subject: Re: RFC: Additional Directory for Extensions
Date: Tue, 25 Feb 2025 07:45:10 -0500
Message-ID: <[email protected]> (raw)
In-Reply-To: <CAFY6G8dzuLXFjONX5E-TvyD5E9r21b5vp1My_nMcqdGD0VYfYw@mail.gmail.com>
References: <CA+TgmoaMk==vOUmWwJ5ZA-EueNqa9RQaWMEiHCF1ZKW_YCcj8g@mail.gmail.com>
	<[email protected]>
	<CA+TgmoYcAmhnSUHKdJsS1wOR-9+y6dbLhfJ3Ad+iZEDmA1mPXg@mail.gmail.com>
	<[email protected]>
	<[email protected]>
	<CA+VUV5oWkMVvtNB0BG2CM8SrmOkeW6fEtXGehbniHqR9MhMzVw@mail.gmail.com>
	<CAGRY4nxP6A5Dz23g+aGD-agdVwUj_qrG6szd-mWc0E5OFMBg4w@mail.gmail.com>
	<[email protected]>
	<CAGRY4ny=Oy-F0qCRFQa=XtEqyUbMygvbqqKahAvbae7v4LTOrQ@mail.gmail.com>
	<[email protected]>
	<CAGRY4nx8Fmea4udk--PKdvfgpNdqC+rcueAmGwuw2PD9dv+zqQ@mail.gmail.com>
	<[email protected]>
	<[email protected]>
	<[email protected]>
	<CAFY6G8dzuLXFjONX5E-TvyD5E9r21b5vp1My_nMcqdGD0VYfYw@mail.gmail.com>


On 2025-02-24 Mo 8:33 AM, Matheus Alcantara wrote:
> Hi,
>
> On Thu, Dec 5, 2024 at 8:07 AM Peter Eisentraut <[email protected]> wrote:
>> This patch is now complete enough for testing, I think.  As I mentioned
>> earlier, I haven't updated pg_available_extensions() etc. to support the
>> path, but that shouldn't prevent some testing.
> To help with this patch I'm attaching a new version with the remaining TODOs
> fixed and also with a new TAP test.
>
> Thoughts?
>


I think your additions generally look good. We should be able to 
simplify this:


+    system_dir = psprintf("%s/extension", sharepath);
+    ecp = system_dir;
+
+    if (strlen(Extension_control_path) == 0)
+    {
+        paths = lappend(paths, ecp);
+    }


cheers


andrew



--
Andrew Dunstan
EDB: https://www.enterprisedb.com

view thread (44+ messages)  latest in thread

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected]
  Subject: Re: RFC: Additional Directory for Extensions
  In-Reply-To: <[email protected]>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox