From: Tom Lane <tgl@sss.pgh.pa.us>
To: Noah Misch <noah@leadboat.com>
cc: Alvaro Herrera <alvherre@alvh.no-ip.org>,
        Michael Paquier <michael@paquier.xyz>,
        Jacob Champion <pchampion@vmware.com>,
        "pgsql-hackers@postgresql.org" <pgsql-hackers@postgresql.org>,
        Daniel Gustafsson <daniel@yesql.se>, info@cspug.cz
Subject: Re: Preventing abort() and exit() calls in libpq
In-reply-to: <20210703001639.GB2374652@rfd.leadboat.com>
References: <202107021459.7c2dkzyg5lua@alvherre.pgsql>
 <819502.1625239217@sss.pgh.pa.us> <20210703001639.GB2374652@rfd.leadboat.com>
Comments: In-reply-to Noah Misch <noah@leadboat.com>
	message dated "Fri, 02 Jul 2021 17:16:39 -0700"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <1231770.1625321413.1@sss.pgh.pa.us>
Date: Sat, 03 Jul 2021 10:10:13 -0400
Message-ID: <1231771.1625321413@sss.pgh.pa.us>
Archived-At: 
 <https://www.postgresql.org/message-id/1231771.1625321413%40sss.pgh.pa.us>
Precedence: bulk

Noah Misch <noah@leadboat.com> writes:
> On Fri, Jul 02, 2021 at 11:20:17AM -0400, Tom Lane wrote:
>> Ugh.  What in the world is producing those references?

> Those come from a statically-linked libldap_r:

Blech!  I wonder if there is some way to avoid counting that.
It's not really hard to imagine that such a library might
contain an exit() call, for example, thus negating our test
altogether.

I'm now wondering about applying the test to *.o in libpq,
as well as libpgport_shlib.a and libpgcommon_shlib.a.
The latter would require some code changes, and it would make
the prohibition extend further than libpq alone.  On the bright
side, we could reinstate the check for abort().

			regards, tom lane