From: Tom Lane <tgl@sss.pgh.pa.us>
To: Andres Freund <andres@anarazel.de>
cc: Peter Eisentraut <peter.eisentraut@enterprisedb.com>,
        David Rowley <dgrowleyml@gmail.com>,
        pgsql-hackers <pgsql-hackers@postgresql.org>
Subject: Re: automatically generating node support functions
In-reply-to: <20220711182915.jd2ibajdcbncqdqd@awork3.anarazel.de>
References: <b9acf63c-6693-d87c-f010-ca8ad502a39f@enterp! risedb.com>
 <3302658.1657288366@sss.pgh.pa.us> <611d2e!
 93-6330-47fa-0970-72316aed50f2@enterprisedb.com>
 <3488143.1657310625@sss.pgh.pa.us>
 <11148777-fbe2-5188-195d-48f5083573c5@enterprisedb.com>
 <20220710214622.haiektrjzisob6rl@awork3.anarazel.de>
 <815831.1657494597@sss.pgh.pa.us>
 <45f508cb-e30b-c252-e081-4548deafa34c@enterprisedb.com>
 <1116889.1657553859@sss.pgh.pa.us> <1201553.1657562258@sss.pgh.pa.us>
 <20220711182915.jd2ibajdcbncqdqd@awork3.anarazel.de>
Comments: In-reply-to Andres Freund <andres@anarazel.de>
	message dated "Mon, 11 Jul 2022 11:29:15 -0700"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <1231809.1657569840.1@sss.pgh.pa.us>
Date: Mon, 11 Jul 2022 16:04:00 -0400
Message-ID: <1231810.1657569840@sss.pgh.pa.us>
Archived-At: 
 <https://www.postgresql.org/message-id/1231810.1657569840%40sss.pgh.pa.us>
Precedence: bulk

Andres Freund <andres@anarazel.de> writes:
> Additionally, I think we've had to add tags to the enum in minor releases
> before and I'm afraid this now would end up looking even more awkward?

Peter and I already had a discussion about that upthread --- we figured
that if there's a way to manually assign a nodetag's number, you could use
that option when you have to add a tag in a stable branch.  We didn't
actually build out that idea, but I can go do that, if we can solve the
more fundamental problem of keeping the autogenerated numbers stable.

One issue with that idea, of course, is that you have to remember to do
it like that when back-patching a node addition.  Ideally there'd be
something that'd carp if the last autogenerated tag moves in a stable
branch, but I'm not very sure where to put that.

			regards, tom lane