Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1luJQE-0007nO-Dq for pgsql-hackers@arkaria.postgresql.org; Fri, 18 Jun 2021 18:40:54 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1luJQD-0003Hq-EM for pgsql-hackers@arkaria.postgresql.org; Fri, 18 Jun 2021 18:40:53 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1luJPo-0007nY-Aq for pgsql-hackers@lists.postgresql.org; Fri, 18 Jun 2021 18:40:28 +0000 Received: from sss.pgh.pa.us ([66.207.139.130]) by makus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1luJPh-0008W7-R1 for pgsql-hackers@lists.postgresql.org; Fri, 18 Jun 2021 18:40:27 +0000 Received: from sss1.sss.pgh.pa.us (localhost [127.0.0.1]) by sss.pgh.pa.us (8.15.2/8.15.2) with ESMTP id 15IIe3nE1234108; Fri, 18 Jun 2021 14:40:03 -0400 From: Tom Lane To: Fabien COELHO cc: PostgreSQL Developers , Thomas Munro Subject: Re: Version reporting in pgbench In-reply-to: References: <1226654.1624036821@sss.pgh.pa.us> Comments: In-reply-to Fabien COELHO message dated "Fri, 18 Jun 2021 20:27:16 +0200" MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <1234106.1624041603.1@sss.pgh.pa.us> Date: Fri, 18 Jun 2021 14:40:03 -0400 Message-ID: <1234107.1624041603@sss.pgh.pa.us> List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk Fabien COELHO writes: > Why not move the printVersion call right after the connection is created, > at line 6374? I started with that, and one of the 001_pgbench_with_server.pl tests fell over --- it was expecting no stdout output before a "Perhaps you need to do initialization" failure. If you don't mind changing that, I agree that printing immediately after the connection is made is a bit less astonishing. regards, tom lane