Received: from malur.postgresql.org ([217.196.149.56])
	by arkaria.postgresql.org with esmtps
 (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256)
	(Exim 4.92)
	(envelope-from <pgsql-hackers-owner+archive@lists.postgresql.org>)
	id 1jy2ri-00034x-Pj
	for pgsql-hackers@arkaria.postgresql.org; Wed, 22 Jul 2020 00:44:10 +0000
Received: from localhost ([127.0.0.1] helo=malur.postgresql.org)
	by malur.postgresql.org with esmtp (Exim 4.92)
	(envelope-from <pgsql-hackers-owner+archive@lists.postgresql.org>)
	id 1jy2rg-0002yY-T6
	for pgsql-hackers@arkaria.postgresql.org; Wed, 22 Jul 2020 00:44:08 +0000
Received: from makus.postgresql.org ([2001:4800:3e1:1::229])
	by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256)
	(Exim 4.92)
	(envelope-from <tgl@sss.pgh.pa.us>)
	id 1jy2rg-0002yR-CA
	for pgsql-hackers@lists.postgresql.org; Wed, 22 Jul 2020 00:44:08 +0000
Received: from sss.pgh.pa.us ([66.207.139.130])
	by makus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256)
	(Exim 4.92)
	(envelope-from <tgl@sss.pgh.pa.us>)
	id 1jy2rZ-0001rs-SI
	for pgsql-hackers@postgresql.org; Wed, 22 Jul 2020 00:44:07 +0000
Received: from sss1.sss.pgh.pa.us (localhost [127.0.0.1])
	by sss.pgh.pa.us (8.15.2/8.15.2) with ESMTP id 06M0hwbi1239157;
	Tue, 21 Jul 2020 20:43:58 -0400
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Michael Paquier <michael@paquier.xyz>
cc: Justin Pryzby <pryzby@telsasoft.com>, pgsql-hackers@postgresql.org
Subject: Re: v13 planner ERROR: could not determine which collation to use for
 string comparison
In-reply-to: <20200722003612.GC9642@paquier.xyz>
References: <20200721191606.GL5748@telsasoft.com>
 <1199426.1595370300@sss.pgh.pa.us> <20200722003612.GC9642@paquier.xyz>
Comments: In-reply-to Michael Paquier <michael@paquier.xyz>
	message dated "Wed, 22 Jul 2020 09:36:12 +0900"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <1239155.1595378638.1@sss.pgh.pa.us>
Date: Tue, 21 Jul 2020 20:43:58 -0400
Message-ID: <1239156.1595378638@sss.pgh.pa.us>
List-Id: <pgsql-hackers.lists.postgresql.org>
List-Help: <https://lists.postgresql.org/manage/>
List-Subscribe: <https://lists.postgresql.org/manage/>
List-Post: <mailto:pgsql-hackers@lists.postgresql.org>
List-Owner: <mailto:pgsql-hackers-owner@lists.postgresql.org>
List-Archive: <https://www.postgresql.org/list/pgsql-hackers>
Precedence: bulk

Michael Paquier <michael@paquier.xyz> writes:
> On Tue, Jul 21, 2020 at 06:25:00PM -0400, Tom Lane wrote:
>> Ugh.  It's clear from your stack trace that neqjoinsel() has forgotten to
>> pass through collation to eqjoinsel().  Will fix.

> Why didn't you include a regression test in bd0d893?

Didn't really see much point.  It's not like anybody's likely to
take out the collation handling now that it's there.

			regards, tom lane